Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1211640 > unrolled thread

[PATCH 1/1] fix cpufreq/cpufreq.c some coding style issues

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/1] fix cpufreq/cpufreq.c some coding style issues Muhammad Falak R Wani <falakreyaz@gmail.com> - 2015-08-23 17:40 +0200
    Re: [PATCH 1/1] fix cpufreq/cpufreq.c some coding style issues Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-24 06:30 +0200
      Re: [PATCH 1/1] fix cpufreq/cpufreq.c some coding style issues Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-08-24 06:40 +0200
    Re: [PATCH 1/1] fix cpufreq/cpufreq.c some coding style issues Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-24 06:30 +0200

#1211640 — [PATCH 1/1] fix cpufreq/cpufreq.c some coding style issues

Hi,

	This patch fixes issues in coding style, of a missing blank line after
declarations.

Best,
mfrw

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
 drivers/cpufreq/cpufreq.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 8ae655c..5aea659 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -718,6 +718,7 @@ static ssize_t show_bios_limit(struct cpufreq_policy *policy, char *buf)
 {
 	unsigned int limit;
 	int ret;
+
 	if (cpufreq_driver->bios_limit) {
 		ret = cpufreq_driver->bios_limit(policy->cpu, &limit);
 		if (!ret)
@@ -815,6 +816,7 @@ unlock:
 static void cpufreq_sysfs_release(struct kobject *kobj)
 {
 	struct cpufreq_policy *policy = to_policy(kobj);
+
 	pr_debug("last reference is dropped\n");
 	complete(&policy->kobj_unregister);
 }
@@ -2129,6 +2131,7 @@ EXPORT_SYMBOL_GPL(cpufreq_unregister_governor);
 int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu)
 {
 	struct cpufreq_policy *cpu_policy;
+
 	if (!policy)
 		return -EINVAL;
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1211768

On 23-08-15, 21:19, Vaishali Thakkar wrote:
> 
> On 23 Aug 2015 21:05, "Muhammad Falak R Wani" <falakreyaz@gmail.com> wrote:
> >
> > Hi,
> >
> >         This patch fixes issues in coding style, of a missing blank line
> after
> > declarations.
> >
> > Best,
> > mfrw
> 
> Please use subject lines and commit log matching the kernel coding style for
> the subsystem on patches.

And Vaishali, please don't send any mails in html. Please configure
your gmail client to send mails only in text.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1211791

On Mon, Aug 24, 2015 at 9:53 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 23-08-15, 21:19, Vaishali Thakkar wrote:
>>
>> On 23 Aug 2015 21:05, "Muhammad Falak R Wani" <falakreyaz@gmail.com> wrote:
>> >
>> > Hi,
>> >
>> >         This patch fixes issues in coding style, of a missing blank line
>> after
>> > declarations.
>> >
>> > Best,
>> > mfrw
>>
>> Please use subject lines and commit log matching the kernel coding style for
>> the subsystem on patches.
>
> And Vaishali, please don't send any mails in html. Please configure
> your gmail client to send mails only in text.

Yes. Sorry. I realized my mistake. Will keep in mind.

> --
> viresh



-- 
Vaishali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1211774

On 23-08-15, 21:09, Muhammad Falak R Wani wrote:
> Hi,
> 
> 	This patch fixes issues in coding style, of a missing blank line after
> declarations.
> 
> Best,
> mfrw

This is as ugly as it could be. Please go through
Documentation/SubmittingPatches and other related stuff to see you to
send patches.

> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
>  drivers/cpufreq/cpufreq.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 8ae655c..5aea659 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -718,6 +718,7 @@ static ssize_t show_bios_limit(struct cpufreq_policy *policy, char *buf)
>  {
>  	unsigned int limit;
>  	int ret;
> +
>  	if (cpufreq_driver->bios_limit) {
>  		ret = cpufreq_driver->bios_limit(policy->cpu, &limit);
>  		if (!ret)
> @@ -815,6 +816,7 @@ unlock:
>  static void cpufreq_sysfs_release(struct kobject *kobj)
>  {
>  	struct cpufreq_policy *policy = to_policy(kobj);
> +
>  	pr_debug("last reference is dropped\n");
>  	complete(&policy->kobj_unregister);
>  }
> @@ -2129,6 +2131,7 @@ EXPORT_SYMBOL_GPL(cpufreq_unregister_governor);
>  int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu)
>  {
>  	struct cpufreq_policy *cpu_policy;
> +
>  	if (!policy)
>  		return -EINVAL;

And then these changes are all trivial and not at all important. We
don't want a patch for that even if checkpatch complains.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web