Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1211774

Re: [PATCH 1/1] fix cpufreq/cpufreq.c some coding style issues

Show all headers | View raw

On 23-08-15, 21:09, Muhammad Falak R Wani wrote:
> Hi,
> 
> 	This patch fixes issues in coding style, of a missing blank line after
> declarations.
> 
> Best,
> mfrw

This is as ugly as it could be. Please go through
Documentation/SubmittingPatches and other related stuff to see you to
send patches.

> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
>  drivers/cpufreq/cpufreq.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 8ae655c..5aea659 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -718,6 +718,7 @@ static ssize_t show_bios_limit(struct cpufreq_policy *policy, char *buf)
>  {
>  	unsigned int limit;
>  	int ret;
> +
>  	if (cpufreq_driver->bios_limit) {
>  		ret = cpufreq_driver->bios_limit(policy->cpu, &limit);
>  		if (!ret)
> @@ -815,6 +816,7 @@ unlock:
>  static void cpufreq_sysfs_release(struct kobject *kobj)
>  {
>  	struct cpufreq_policy *policy = to_policy(kobj);
> +
>  	pr_debug("last reference is dropped\n");
>  	complete(&policy->kobj_unregister);
>  }
> @@ -2129,6 +2131,7 @@ EXPORT_SYMBOL_GPL(cpufreq_unregister_governor);
>  int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu)
>  {
>  	struct cpufreq_policy *cpu_policy;
> +
>  	if (!policy)
>  		return -EINVAL;

And then these changes are all trivial and not at all important. We
don't want a patch for that even if checkpatch complains.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] fix cpufreq/cpufreq.c some coding style issues Muhammad Falak R Wani <falakreyaz@gmail.com> - 2015-08-23 17:40 +0200
  Re: [PATCH 1/1] fix cpufreq/cpufreq.c some coding style issues Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-24 06:30 +0200
    Re: [PATCH 1/1] fix cpufreq/cpufreq.c some coding style issues Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-08-24 06:40 +0200
  Re: [PATCH 1/1] fix cpufreq/cpufreq.c some coding style issues Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-24 06:30 +0200

csiph-web