Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1157855 > unrolled thread

Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code  in arch/x86/entry/ "H. Peter Anvin" <hpa@zytor.com> - 2015-06-03 19:10 +0200
    Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code  in arch/x86/entry/ Andy Lutomirski <luto@amacapital.net> - 2015-06-03 19:20 +0200
      Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code  in arch/x86/entry/ Ingo Molnar <mingo@kernel.org> - 2015-06-03 19:20 +0200
    Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code  in arch/x86/entry/ Ingo Molnar <mingo@kernel.org> - 2015-06-03 19:20 +0200

#1157855 — Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/

On 06/03/2015 09:59 AM, Ingo Molnar wrote:
> So the x86 syscall/irq/etc. entry code is scattered in
> over 40 files all over the x86 architecture, making it
> hard to get a good overview of the code and its current
> status.
> 
> Move all the files to arch/x86/entry/.
> 
> This first step is as-is, no file names were changed - but the next
> step will be to organize things in a bit more maintainable fashion.
> 
> If there are no fundamental objections then I'll commit this to
> tip:x86/asm. (I've drained most of the pending patches to these
> files - but porting them should be easy in any case.)

I would prefer if it was made a separate topic.

I like the patch set (and you can add my Acked-by:) *except* 7/7, and
the reason for that is that it really isn't entry code, it is user space
code.

I also dislike deep directory hierarchies in general, unless it really
be avoided, like boot/ or realmode/.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1157905

On Wed, Jun 3, 2015 at 10:11 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * H. Peter Anvin <hpa@zytor.com> wrote:
>
>> I like the patch set (and you can add my Acked-by:) *except* 7/7, and the reason
>> for that is that it really isn't entry code, it is user space code.
>
> Well, I think arch/x86/entry/ should be a broader category for all things entry
> code: and the vsyscall code is closely related to the syscall entry/exit code so
> it's in a better place there than just being in the generic arch/x86/kernel/
> directory.
>
> I kept it separate in arch/x86/entry/vsyscall/ so it doesn't mix with other entry
> code.

...and my reading comprehension is way off this morning.  You already
called it arch/x86/entry, so there was no reason for me to suggest
that :)

Anyway, arch/x86/entry/vdso isn't so bad.  It's just a bit odd sounding to me.

--Andy

>
> Thanks,
>
>         Ingo



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1157906

* Andy Lutomirski <luto@amacapital.net> wrote:

> On Wed, Jun 3, 2015 at 10:11 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * H. Peter Anvin <hpa@zytor.com> wrote:
> >
> >> I like the patch set (and you can add my Acked-by:) *except* 7/7, and the reason
> >> for that is that it really isn't entry code, it is user space code.
> >
> > Well, I think arch/x86/entry/ should be a broader category for all things entry
> > code: and the vsyscall code is closely related to the syscall entry/exit code so
> > it's in a better place there than just being in the generic arch/x86/kernel/
> > directory.
> >
> > I kept it separate in arch/x86/entry/vsyscall/ so it doesn't mix with other entry
> > code.
> 
> ...and my reading comprehension is way off this morning.  You already called it 
> arch/x86/entry, so there was no reason for me to suggest that :)
> 
> Anyway, arch/x86/entry/vdso isn't so bad.  It's just a bit odd sounding to me.

We could make it arch/x86/sys/? Sounds a bit too generic though.

Didn't want to limit it to system calls only, because there's various other entry 
methods (irqs, traps, NMI, etc.) that we want to handle in a coherent fashion. 
[ Which you are intimately aware of ;-) ]

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1157915

* H. Peter Anvin <hpa@zytor.com> wrote:

> I like the patch set (and you can add my Acked-by:) *except* 7/7, and the reason 
> for that is that it really isn't entry code, it is user space code.

Well, I think arch/x86/entry/ should be a broader category for all things entry 
code: and the vsyscall code is closely related to the syscall entry/exit code so 
it's in a better place there than just being in the generic arch/x86/kernel/ 
directory.

I kept it separate in arch/x86/entry/vsyscall/ so it doesn't mix with other entry 
code.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web