Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1157855

Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/

From "H. Peter Anvin" <hpa@zytor.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code in arch/x86/entry/
Date 2015-06-03 19:10 +0200
Message-ID <pxkkV-7sr-1@gated-at.bofh.it> (permalink)
References <pxkkV-7sr-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 06/03/2015 09:59 AM, Ingo Molnar wrote:
> So the x86 syscall/irq/etc. entry code is scattered in
> over 40 files all over the x86 architecture, making it
> hard to get a good overview of the code and its current
> status.
> 
> Move all the files to arch/x86/entry/.
> 
> This first step is as-is, no file names were changed - but the next
> step will be to organize things in a bit more maintainable fashion.
> 
> If there are no fundamental objections then I'll commit this to
> tip:x86/asm. (I've drained most of the pending patches to these
> files - but porting them should be easy in any case.)

I would prefer if it was made a separate topic.

I like the patch set (and you can add my Acked-by:) *except* 7/7, and
the reason for that is that it really isn't entry code, it is user space
code.

I also dislike deep directory hierarchies in general, unless it really
be avoided, like boot/ or realmode/.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code  in arch/x86/entry/ "H. Peter Anvin" <hpa@zytor.com> - 2015-06-03 19:10 +0200
  Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code  in arch/x86/entry/ Andy Lutomirski <luto@amacapital.net> - 2015-06-03 19:20 +0200
    Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code  in arch/x86/entry/ Ingo Molnar <mingo@kernel.org> - 2015-06-03 19:20 +0200
  Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code  in arch/x86/entry/ Ingo Molnar <mingo@kernel.org> - 2015-06-03 19:20 +0200

csiph-web