Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1156980 > unrolled thread

Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros definition

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros  definition Daniel Axtens <dja@axtens.net> - 2015-06-03 01:20 +0200
    Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros definition Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-06-04 09:50 +0200
    Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros  definition Mike & Meg <mikenmeg@ellerman.id.au> - 2015-06-04 12:50 +0200

#1156980 — Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros definition

[Multipart message — attachments visible in raw view] — view raw

> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version
> + * 2 of the License, or (at your option) any later version.
> + */

I'm not certain about this, but I _think_ this is supposed to be version
2 only:
http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/COPYING#n9


> +/*
> + * Device tree parser code detect nest pmu support
> + * and create new nest pmus. This structure will
> + * hold the pmu functions and attrs for each nest pmu and
> + * will be referenced at the time of pmu registering.
> + */

The first sentence of that comment is unclear: I think your trying to
say "Device tree parser code detects nest pmu support and registers new
nest pmus"? Also s/registering/registration/.

> +struct nest_pmu {
> +	struct pmu pmu;
> +	const struct attribute_group *attr_groups[4];
> +};
> +

Regards,
Daniel Axtens

[toc] | [next] | [standalone]

#1158318 — Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros definition

On Wednesday 03 June 2015 04:41 AM, Daniel Axtens wrote:
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License
>> + * as published by the Free Software Foundation; either version
>> + * 2 of the License, or (at your option) any later version.
>> + */
> I'm not certain about this, but I _think_ this is supposed to be version
> 2 only:
> http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/COPYING#n9
I referred other files for license information from the same folder. So 
I could wait
for the maintainers comment on this.
>
>> +/*
>> + * Device tree parser code detect nest pmu support
>> + * and create new nest pmus. This structure will
>> + * hold the pmu functions and attrs for each nest pmu and
>> + * will be referenced at the time of pmu registering.
>> + */
> The first sentence of that comment is unclear: I think your trying to
> say "Device tree parser code detects nest pmu support and registers new
> nest pmus"? Also s/registering/registration/.
Yes. I will rewrite the comment.

>> +struct nest_pmu {
>> +	struct pmu pmu;
>> +	const struct attribute_group *attr_groups[4];
>> +};
>> +
> Regards,
> Daniel Axtens
Thanks for the review
Maddy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1158450

On Wed, 2015-06-03 at 09:11 +1000, Daniel Axtens wrote:
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License
> > + * as published by the Free Software Foundation; either version
> > + * 2 of the License, or (at your option) any later version.
> > + */
> 
> I'm not certain about this, but I _think_ this is supposed to be version
> 2 only:
> http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/COPYING#n9

Urgh.

Yeah you're right, but we've been very sloppy about that over the years. And so
we have a lot of files that say .. or later.

And now that they say that we can't change them.

For a new file though we should just use the v2 only wording.

  This program is free software; you can redistribute it and/or modify it
  under the terms of the GNU General Public License version 2 as published
  by the Free Software Foundation.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web