Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1156980

Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros definition

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version
> + * 2 of the License, or (at your option) any later version.
> + */

I'm not certain about this, but I _think_ this is supposed to be version
2 only:
http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/COPYING#n9


> +/*
> + * Device tree parser code detect nest pmu support
> + * and create new nest pmus. This structure will
> + * hold the pmu functions and attrs for each nest pmu and
> + * will be referenced at the time of pmu registering.
> + */

The first sentence of that comment is unclear: I think your trying to
say "Device tree parser code detects nest pmu support and registers new
nest pmus"? Also s/registering/registration/.

> +struct nest_pmu {
> +	struct pmu pmu;
> +	const struct attribute_group *attr_groups[4];
> +};
> +

Regards,
Daniel Axtens

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros  definition Daniel Axtens <dja@axtens.net> - 2015-06-03 01:20 +0200
  Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros definition Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-06-04 09:50 +0200
  Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros  definition Mike & Meg <mikenmeg@ellerman.id.au> - 2015-06-04 12:50 +0200

csiph-web