Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210155 > unrolled thread
| Started by | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| First post | 2015-08-20 07:50 +0200 |
| Last post | 2015-08-20 09:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver Vinod Koul <vinod.koul@intel.com> - 2015-08-20 07:50 +0200
Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver Rameshwar Sahu <rsahu@apm.com> - 2015-08-20 09:10 +0200
Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver Vinod Koul <vinod.koul@intel.com> - 2015-08-20 09:10 +0200
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Date | 2015-08-20 07:50 +0200 |
| Subject | Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver |
| Message-ID | <pZqTE-42v-5@gated-at.bofh.it> |
On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote:
> + nents = sg_nents(req->src);
> + sg_count = dma_map_sg(dev, req->src, nents, DMA_TO_DEVICE);
> + if (!sg_count) {
> + dev_err(dev, "Failed to map src sg");
> + return -ENOMEM;
mapping error shouldn't be no mem error
> + }
> +
> + if (sg_count > XGENE_DMA_MAX_FLYBY_SRC_CNT) {
> + dev_err(dev, "Unsupported src sg len\n");
would be worth printing length
> + goto err;
> + }
> +
> + flags = DMA_CTRL_ACK;
why ACK?
> +
> + tx = dchan->device->device_prep_dma_crc32c(dchan, req->src,
> + req->nbytes,
> + reqctx->seed,
> + req->result,
> + flags);
We should add helper for this
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Rameshwar Sahu <rsahu@apm.com> |
|---|---|
| Date | 2015-08-20 09:10 +0200 |
| Message-ID | <pZs94-65q-7@gated-at.bofh.it> |
| In reply to | #1210155 |
Hi Vinod,
On Thu, Aug 20, 2015 at 11:18 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote:
>> + nents = sg_nents(req->src);
>> + sg_count = dma_map_sg(dev, req->src, nents, DMA_TO_DEVICE);
>> + if (!sg_count) {
>> + dev_err(dev, "Failed to map src sg");
>> + return -ENOMEM;
> mapping error shouldn't be no mem error
Okay, I guess then -EIO will be fine here??
>
>> + }
>> +
>> + if (sg_count > XGENE_DMA_MAX_FLYBY_SRC_CNT) {
>> + dev_err(dev, "Unsupported src sg len\n");
> would be worth printing length
Okay,
>
>> + goto err;
>> + }
>> +
>> + flags = DMA_CTRL_ACK;
> why ACK?
My understanding about DMA_CTRL_ACK is dma engine driver can
re-use/free this descriptor once operation completed in cleanup path.
Am I correct ??
But yes, I need to look on this because recently you have added one
more descriptor flag.
>
>> +
>> + tx = dchan->device->device_prep_dma_crc32c(dchan, req->src,
>> + req->nbytes,
>> + reqctx->seed,
>> + req->result,
>> + flags);
> We should add helper for this
Okay
>
> --
> ~Vinod
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Date | 2015-08-20 09:10 +0200 |
| Message-ID | <pZs94-65q-11@gated-at.bofh.it> |
| In reply to | #1210206 |
On Thu, Aug 20, 2015 at 12:31:44PM +0530, Rameshwar Sahu wrote:
> Hi Vinod,
>
> On Thu, Aug 20, 2015 at 11:18 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote:
> >> + nents = sg_nents(req->src);
> >> + sg_count = dma_map_sg(dev, req->src, nents, DMA_TO_DEVICE);
> >> + if (!sg_count) {
> >> + dev_err(dev, "Failed to map src sg");
> >> + return -ENOMEM;
> > mapping error shouldn't be no mem error
> Okay, I guess then -EIO will be fine here??
yes better
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web