Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210155
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver |
| Date | 2015-08-20 07:50 +0200 |
| Message-ID | <pZqTE-42v-5@gated-at.bofh.it> (permalink) |
| References | <pRUYx-6sC-9@gated-at.bofh.it> <pRUYy-6sC-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote:
> + nents = sg_nents(req->src);
> + sg_count = dma_map_sg(dev, req->src, nents, DMA_TO_DEVICE);
> + if (!sg_count) {
> + dev_err(dev, "Failed to map src sg");
> + return -ENOMEM;
mapping error shouldn't be no mem error
> + }
> +
> + if (sg_count > XGENE_DMA_MAX_FLYBY_SRC_CNT) {
> + dev_err(dev, "Unsupported src sg len\n");
would be worth printing length
> + goto err;
> + }
> +
> + flags = DMA_CTRL_ACK;
why ACK?
> +
> + tx = dchan->device->device_prep_dma_crc32c(dchan, req->src,
> + req->nbytes,
> + reqctx->seed,
> + req->result,
> + flags);
We should add helper for this
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver Vinod Koul <vinod.koul@intel.com> - 2015-08-20 07:50 +0200
Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver Rameshwar Sahu <rsahu@apm.com> - 2015-08-20 09:10 +0200
Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver Vinod Koul <vinod.koul@intel.com> - 2015-08-20 09:10 +0200
csiph-web