Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1208535 > unrolled thread
| Started by | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| First post | 2015-08-17 13:20 +0200 |
| Last post | 2015-08-19 18:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-08-17 13:20 +0200
Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe Andy Lutomirski <luto@amacapital.net> - 2015-08-19 18:00 +0200
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2015-08-17 13:20 +0200 |
| Subject | Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe |
| Message-ID | <pYqCm-5HD-21@gated-at.bofh.it> |
On Sat, Jul 25, 2015 at 8:57 AM, Andy Lutomirski <luto@kernel.org> wrote: > This will allow IRQ stacks to nest inside NMIs or similar entries > that can happen during IRQ stack setup or teardown. > > The Xen code here has a confusing comment. > > The new macros won't work correctly if they're invoked with IRQs on. > Add a check under CONFIG_DEBUG_ENTRY to detect that. > > +/* > + * Enters the IRQ stack if we're not already using it. NMI-safe. Clobbers > + * flags and puts old RSP into old_rsp, and leaves all other GPRs alone. > + * Requires kernel GSBASE. > + * > + * The invariant is that, if irq_count != 1, then the IRQ stack is in use. > + */ I might be wrong, but shouldn't be this read as 'if irq_count != -1' ? -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Andy Lutomirski <luto@amacapital.net> |
|---|---|
| Date | 2015-08-19 18:00 +0200 |
| Message-ID | <pZdWq-20e-17@gated-at.bofh.it> |
| In reply to | #1208535 |
On Mon, Aug 17, 2015 at 4:18 AM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Sat, Jul 25, 2015 at 8:57 AM, Andy Lutomirski <luto@kernel.org> wrote: >> This will allow IRQ stacks to nest inside NMIs or similar entries >> that can happen during IRQ stack setup or teardown. >> >> The Xen code here has a confusing comment. >> >> The new macros won't work correctly if they're invoked with IRQs on. >> Add a check under CONFIG_DEBUG_ENTRY to detect that. >> > >> +/* >> + * Enters the IRQ stack if we're not already using it. NMI-safe. Clobbers >> + * flags and puts old RSP into old_rsp, and leaves all other GPRs alone. >> + * Requires kernel GSBASE. >> + * >> + * The invariant is that, if irq_count != 1, then the IRQ stack is in use. >> + */ > > I might be wrong, but shouldn't be this read as 'if irq_count != -1' ? > Indeed. Will fix for the next version. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web