Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1210506 > unrolled thread

[PATCH] staging: fbtft: Removed a space

Started byAparna Karuthodi <kdasaparna@gmail.com>
First post2015-08-20 16:00 +0200
Last post2015-08-24 15:10 +0200
Articles 10 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: fbtft: Removed a space Aparna Karuthodi <kdasaparna@gmail.com> - 2015-08-20 16:00 +0200
    Re: [PATCH] staging: fbtft: Removed a space Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-21 13:10 +0200
    [PATCH] staging: fbtft: Removed a space Aparna Karuthodi <kdasaparna@gmail.com> - 2015-08-21 14:30 +0200
      Re: [PATCH] staging: fbtft: Removed a space Mike Rapoport <mike.rapoport@gmail.com> - 2015-08-21 14:40 +0200
    [PATCH] staging: fbtft: Removed a space Aparna Karuthodi <kdasaparna@gmail.com> - 2015-08-21 15:10 +0200
      Re: [PATCH] staging: fbtft: Removed a space Mike Rapoport <mike.rapoport@gmail.com> - 2015-08-21 15:30 +0200
      Re: [PATCH] staging: fbtft: Removed a space Greg KH <gregkh@linuxfoundation.org> - 2015-09-03 03:20 +0200
    [PATCH] staging: fbtft: Removed a space Aparna Karuthodi <kdasaparna@gmail.com> - 2015-08-21 15:50 +0200
    [PATCH] staging: fbtft: Removed space before parenthesis Aparna Karuthodi <kdasaparna@gmail.com> - 2015-08-21 17:40 +0200
      Re: [PATCH] staging: fbtft: Removed space before parenthesis Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-24 15:10 +0200

#1210506 — [PATCH] staging: fbtft: Removed a space

FromAparna Karuthodi <kdasaparna@gmail.com>
Date2015-08-20 16:00 +0200
Subject[PATCH] staging: fbtft: Removed a space
Message-ID<pZyxR-6Jf-43@gated-at.bofh.it>
Removed a space before parenthesis to remove a coding style error
detected by checkpatch.
The error is given below:
drivers/staging/fbtft/fb_bd663474.c:118: ERROR: space prohibited before
that close parenthesis ')'

Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
---
 drivers/staging/fbtft/fb_bd663474.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c b/drivers/staging/fbtft/fb_bd663474.c
index 7e00c60..8619426 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x100, 0x7120 );
 	write_reg(par, 0x007, 0x0103 );
 	mdelay( 10 );
-	write_reg(par, 0x007, 0x0113 );
+	write_reg(par, 0x007, 0x0113);
 
 	return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1211117

FromDan Carpenter <dan.carpenter@oracle.com>
Date2015-08-21 13:10 +0200
Message-ID<pZSmS-1Ob-1@gated-at.bofh.it>
In reply to#1210506
On Thu, Aug 20, 2015 at 07:26:59PM +0530, Aparna Karuthodi wrote:
> Removed a space before parenthesis to remove a coding style error
> detected by checkpatch.
> The error is given below:
> drivers/staging/fbtft/fb_bd663474.c:118: ERROR: space prohibited before
> that close parenthesis ')'
> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
>  drivers/staging/fbtft/fb_bd663474.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_bd663474.c b/drivers/staging/fbtft/fb_bd663474.c
> index 7e00c60..8619426 100644
> --- a/drivers/staging/fbtft/fb_bd663474.c
> +++ b/drivers/staging/fbtft/fb_bd663474.c
> @@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
>  	write_reg(par, 0x100, 0x7120 );
>  	write_reg(par, 0x007, 0x0103 );
>  	mdelay( 10 );
> -	write_reg(par, 0x007, 0x0113 );
> +	write_reg(par, 0x007, 0x0113);

Every other line in the surrounding context has the same issue.  Please
don't just change one line at a time like this...  It is a waste of our
time.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1211130

FromAparna Karuthodi <kdasaparna@gmail.com>
Date2015-08-21 14:30 +0200
Message-ID<pZTCi-3vt-23@gated-at.bofh.it>
In reply to#1210506
Okay. I will make the necessary changes and send it again.
If I am making changes in each of the lines, should I send it as a
patchset?

Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
---
 drivers/staging/fbtft/fb_bd663474.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c b/drivers/staging/fbtft/fb_bd663474.c
index 7e00c60..8619426 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x100, 0x7120 );
 	write_reg(par, 0x007, 0x0103 );
 	mdelay( 10 );
-	write_reg(par, 0x007, 0x0113 );
+	write_reg(par, 0x007, 0x0113);
 
 	return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1211139

FromMike Rapoport <mike.rapoport@gmail.com>
Date2015-08-21 14:40 +0200
Message-ID<pZTLZ-3GC-41@gated-at.bofh.it>
In reply to#1211130
On Fri, Aug 21, 2015 at 05:55:28PM +0530, Aparna Karuthodi wrote:
> Okay. I will make the necessary changes and send it again.
> If I am making changes in each of the lines, should I send it as a
> patchset?

It seems that these checkpatch errors were already fixed in commit that
was already merged:

commit 171c44fcbbf243a327cd2667a74b59b871489b91
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Date:   Tue Feb 17 19:48:51 2015 +0200

    staging: fbtft: fix spacing errors

Are you sure you have the recent kernel tree?
 
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
>  drivers/staging/fbtft/fb_bd663474.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_bd663474.c b/drivers/staging/fbtft/fb_bd663474.c
> index 7e00c60..8619426 100644
> --- a/drivers/staging/fbtft/fb_bd663474.c
> +++ b/drivers/staging/fbtft/fb_bd663474.c
> @@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
>  	write_reg(par, 0x100, 0x7120 );
>  	write_reg(par, 0x007, 0x0103 );
>  	mdelay( 10 );
> -	write_reg(par, 0x007, 0x0113 );
> +	write_reg(par, 0x007, 0x0113);
>  
>  	return 0;
>  }
> -- 
> 1.7.9.5
 
--
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1211153

FromAparna Karuthodi <kdasaparna@gmail.com>
Date2015-08-21 15:10 +0200
Message-ID<pZUf2-4u1-49@gated-at.bofh.it>
In reply to#1210506
I fetched it yesterday using git fetch origin master. So, I thought I am in the recent kernel tree.

Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
---
 drivers/staging/fbtft/fb_bd663474.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c b/drivers/staging/fbtft/fb_bd663474.c
index 7e00c60..8619426 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x100, 0x7120 );
 	write_reg(par, 0x007, 0x0103 );
 	mdelay( 10 );
-	write_reg(par, 0x007, 0x0113 );
+	write_reg(par, 0x007, 0x0113);
 
 	return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1211167

FromMike Rapoport <mike.rapoport@gmail.com>
Date2015-08-21 15:30 +0200
Message-ID<pZUyn-4R5-39@gated-at.bofh.it>
In reply to#1211153
On Fri, Aug 21, 2015 at 06:31:33PM +0530, Aparna Karuthodi wrote:
> I fetched it yesterday using git fetch origin master. So, I thought I am in the recent kernel tree.

In current Linus' tree the fb_bd663474 driver does not have these style
errors.
Either your 'origin' is pointing to some tree that was not updated for a
long time, or you've only fetched the latest changes from the remote and
haven't merged them into your working tree.
 
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
>  drivers/staging/fbtft/fb_bd663474.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_bd663474.c b/drivers/staging/fbtft/fb_bd663474.c
> index 7e00c60..8619426 100644
> --- a/drivers/staging/fbtft/fb_bd663474.c
> +++ b/drivers/staging/fbtft/fb_bd663474.c
> @@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
>  	write_reg(par, 0x100, 0x7120 );
>  	write_reg(par, 0x007, 0x0103 );
>  	mdelay( 10 );
> -	write_reg(par, 0x007, 0x0113 );
> +	write_reg(par, 0x007, 0x0113);
>  
>  	return 0;
>  }
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1217991

FromGreg KH <gregkh@linuxfoundation.org>
Date2015-09-03 03:20 +0200
Message-ID<q4rm2-5k7-15@gated-at.bofh.it>
In reply to#1211153
On Fri, Aug 21, 2015 at 06:31:33PM +0530, Aparna Karuthodi wrote:
> I fetched it yesterday using git fetch origin master. So, I thought I am in the recent kernel tree.

That's a horrible changelog text :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1211184

FromAparna Karuthodi <kdasaparna@gmail.com>
Date2015-08-21 15:50 +0200
Message-ID<pZURH-5fy-7@gated-at.bofh.it>
In reply to#1210506
Now I understood my mistake. I was calling git fetch or git pull not from master branch. Now when I ran that command from master branch it's working.

Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
---
 drivers/staging/fbtft/fb_bd663474.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c b/drivers/staging/fbtft/fb_bd663474.c
index 7e00c60..8619426 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x100, 0x7120 );
 	write_reg(par, 0x007, 0x0103 );
 	mdelay( 10 );
-	write_reg(par, 0x007, 0x0113 );
+	write_reg(par, 0x007, 0x0113);
 
 	return 0;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1211220 — [PATCH] staging: fbtft: Removed space before parenthesis

FromAparna Karuthodi <kdasaparna@gmail.com>
Date2015-08-21 17:40 +0200
Subject[PATCH] staging: fbtft: Removed space before parenthesis
Message-ID<pZWAa-7LJ-11@gated-at.bofh.it>
In reply to#1210506
Removed space before parenthesis in two different lines to remove coding
style errors detected by checkpatch.
The errors are given below:
drivers/staging/fbtft/fbtft-bus.c:73: ERROR: space prohibited before
that close parenthesis ')'
drivers/staging/fbtft/fbtft-bus.c:75: ERROR: space prohibited before
that close parenthesis ')'

Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
---
 drivers/staging/fbtft/fbtft-bus.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index b3cddb0..791fab3 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -70,9 +70,9 @@ void func(struct fbtft_par *par, int len, ...)                                \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1212160 — Re: [PATCH] staging: fbtft: Removed space before parenthesis

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2015-08-24 15:10 +0200
SubjectRe: [PATCH] staging: fbtft: Removed space before parenthesis
Message-ID<q0ZFD-9c-11@gated-at.bofh.it>
In reply to#1211220
On Fri, Aug 21, 2015 at 09:05:47PM +0530, Aparna Karuthodi wrote:
> Removed space before parenthesis in two different lines to remove coding
> style errors detected by checkpatch.
> The errors are given below:
> drivers/staging/fbtft/fbtft-bus.c:73: ERROR: space prohibited before
> that close parenthesis ')'
> drivers/staging/fbtft/fbtft-bus.c:75: ERROR: space prohibited before
> that close parenthesis ')'
> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
>  drivers/staging/fbtft/fbtft-bus.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index b3cddb0..791fab3 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -70,9 +70,9 @@ void func(struct fbtft_par *par, int len, ...)                                \
>  }                                                                             \
>  EXPORT_SYMBOL(func);
>  
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
>  define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
> -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
Did you build test it?
You have removed ',' while removing the space and that breaks the build.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web