Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1211117

Re: [PATCH] staging: fbtft: Removed a space

Show all headers | View raw

On Thu, Aug 20, 2015 at 07:26:59PM +0530, Aparna Karuthodi wrote:
> Removed a space before parenthesis to remove a coding style error
> detected by checkpatch.
> The error is given below:
> drivers/staging/fbtft/fb_bd663474.c:118: ERROR: space prohibited before
> that close parenthesis ')'
> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
>  drivers/staging/fbtft/fb_bd663474.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_bd663474.c b/drivers/staging/fbtft/fb_bd663474.c
> index 7e00c60..8619426 100644
> --- a/drivers/staging/fbtft/fb_bd663474.c
> +++ b/drivers/staging/fbtft/fb_bd663474.c
> @@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
>  	write_reg(par, 0x100, 0x7120 );
>  	write_reg(par, 0x007, 0x0103 );
>  	mdelay( 10 );
> -	write_reg(par, 0x007, 0x0113 );
> +	write_reg(par, 0x007, 0x0113);

Every other line in the surrounding context has the same issue.  Please
don't just change one line at a time like this...  It is a waste of our
time.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: fbtft: Removed a space Aparna Karuthodi <kdasaparna@gmail.com> - 2015-08-20 16:00 +0200
  Re: [PATCH] staging: fbtft: Removed a space Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-21 13:10 +0200
  [PATCH] staging: fbtft: Removed a space Aparna Karuthodi <kdasaparna@gmail.com> - 2015-08-21 14:30 +0200
    Re: [PATCH] staging: fbtft: Removed a space Mike Rapoport <mike.rapoport@gmail.com> - 2015-08-21 14:40 +0200
  [PATCH] staging: fbtft: Removed a space Aparna Karuthodi <kdasaparna@gmail.com> - 2015-08-21 15:10 +0200
    Re: [PATCH] staging: fbtft: Removed a space Mike Rapoport <mike.rapoport@gmail.com> - 2015-08-21 15:30 +0200
    Re: [PATCH] staging: fbtft: Removed a space Greg KH <gregkh@linuxfoundation.org> - 2015-09-03 03:20 +0200
  [PATCH] staging: fbtft: Removed a space Aparna Karuthodi <kdasaparna@gmail.com> - 2015-08-21 15:50 +0200
  [PATCH] staging: fbtft: Removed space before parenthesis Aparna Karuthodi <kdasaparna@gmail.com> - 2015-08-21 17:40 +0200
    Re: [PATCH] staging: fbtft: Removed space before parenthesis Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-24 15:10 +0200

csiph-web