Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200861 > unrolled thread

[PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode

Started byAlexey Brodkin <Alexey.Brodkin@synopsys.com>
First post2015-08-05 17:20 +0200
Last post2015-08-20 13:40 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-08-05 17:20 +0200
    Re: [PATCH v2 6/8] ARCv2: perf: implement exclusion of event  counting in user or kernel mode Peter Zijlstra <peterz@infradead.org> - 2015-08-19 01:40 +0200
      RE: [PATCH v2 6/8] ARCv2: perf: implement exclusion of event  counting in user or kernel mode Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-08-20 13:40 +0200

#1200861 — [PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode

FromAlexey Brodkin <Alexey.Brodkin@synopsys.com>
Date2015-08-05 17:20 +0200
Subject[PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode
Message-ID<pU8E2-57u-35@gated-at.bofh.it>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
---

No changes since v1.

 arch/arc/include/asm/perf_event.h |  3 +++
 arch/arc/kernel/perf_event.c      | 16 ++++++++++++++--
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/arch/arc/include/asm/perf_event.h b/arch/arc/include/asm/perf_event.h
index 33a6eb2..e915c0d 100644
--- a/arch/arc/include/asm/perf_event.h
+++ b/arch/arc/include/asm/perf_event.h
@@ -37,6 +37,9 @@
 #define ARC_REG_PCT_INT_CTRL	0x25E
 #define ARC_REG_PCT_INT_ACT	0x25F
 
+#define ARC_REG_PCT_CONFIG_USER	(1 << 18)	/* count in user mode */
+#define ARC_REG_PCT_CONFIG_KERN	(1 << 19)	/* count in kernel mode */
+
 #define ARC_REG_PCT_CONTROL_CC	(1 << 16)	/* clear counts */
 #define ARC_REG_PCT_CONTROL_SN	(1 << 17)	/* snapshot */
 
diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c
index 81847ef..3203141 100644
--- a/arch/arc/kernel/perf_event.c
+++ b/arch/arc/kernel/perf_event.c
@@ -161,13 +161,25 @@ static int arc_pmu_event_init(struct perf_event *event)
 		local64_set(&hwc->period_left, hwc->sample_period);
 	}
 
+	hwc->config = 0;
+
+	if (is_isa_arcv2()) {
+		/* "exclude user" means "count only kernel" */
+		if (event->attr.exclude_user)
+			hwc->config |= ARC_REG_PCT_CONFIG_KERN;
+
+		/* "exclude kernel" means "count only user" */
+		if (event->attr.exclude_kernel)
+			hwc->config |= ARC_REG_PCT_CONFIG_USER;
+	}
+
 	switch (event->attr.type) {
 	case PERF_TYPE_HARDWARE:
 		if (event->attr.config >= PERF_COUNT_HW_MAX)
 			return -ENOENT;
 		if (arc_pmu->ev_hw_idx[event->attr.config] < 0)
 			return -ENOENT;
-		hwc->config = arc_pmu->ev_hw_idx[event->attr.config];
+		hwc->config |= arc_pmu->ev_hw_idx[event->attr.config];
 		pr_debug("init event %d with h/w %d \'%s\'\n",
 			 (int) event->attr.config, (int) hwc->config,
 			 arc_pmu_ev_hw_map[event->attr.config]);
@@ -177,7 +189,7 @@ static int arc_pmu_event_init(struct perf_event *event)
 		ret = arc_pmu_cache_event(event->attr.config);
 		if (ret < 0)
 			return ret;
-		hwc->config = arc_pmu->ev_hw_idx[ret];
+		hwc->config |= arc_pmu->ev_hw_idx[ret];
 		return 0;
 
 	case PERF_TYPE_RAW:
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1209540 — Re: [PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode

FromPeter Zijlstra <peterz@infradead.org>
Date2015-08-19 01:40 +0200
SubjectRe: [PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode
Message-ID<pYYE1-5ai-1@gated-at.bofh.it>
In reply to#1200861
On Wed, Aug 05, 2015 at 06:13:32PM +0300, Alexey Brodkin wrote:
> +	hwc->config = 0;
> +
> +	if (is_isa_arcv2()) {
> +		/* "exclude user" means "count only kernel" */
> +		if (event->attr.exclude_user)
> +			hwc->config |= ARC_REG_PCT_CONFIG_KERN;
> +
> +		/* "exclude kernel" means "count only user" */
> +		if (event->attr.exclude_kernel)
> +			hwc->config |= ARC_REG_PCT_CONFIG_USER;
> +	}
> +
>  	switch (event->attr.type) {
>  	case PERF_TYPE_HARDWARE:
>  		if (event->attr.config >= PERF_COUNT_HW_MAX)
>  			return -ENOENT;
>  		if (arc_pmu->ev_hw_idx[event->attr.config] < 0)
>  			return -ENOENT;
> -		hwc->config = arc_pmu->ev_hw_idx[event->attr.config];
> +		hwc->config |= arc_pmu->ev_hw_idx[event->attr.config];

So I would still very much like perf_event_attr::config to reflect the
value you'll program into hardware.

If you want to do that weird 4 character lookup thing, use a special
hardware event (possibly 0 if that is not a valid value), and stuff the
4 chars in ::config1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1210439 — RE: [PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode

FromAlexey Brodkin <Alexey.Brodkin@synopsys.com>
Date2015-08-20 13:40 +0200
SubjectRE: [PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode
Message-ID<pZwmm-3AQ-21@gated-at.bofh.it>
In reply to#1209540
Hi Peter,

> -----Original Message-----
> From: Peter Zijlstra [mailto:peterz@infradead.org]
> Sent: 19 августа 2015 г. 2:37
> To: Alexey Brodkin
> Cc: linux-arch@vger.kernel.org; linux-kernel@vger.kernel.org; Vineet.Gupta1@synopsys.com; arc-linux-dev@synopsys.com;
> arnd@arndb.de; Arnaldo Carvalho de Melo
> Subject: Re: [PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode
> 
> On Wed, Aug 05, 2015 at 06:13:32PM +0300, Alexey Brodkin wrote:
> > +	hwc->config = 0;
> > +
> > +	if (is_isa_arcv2()) {
> > +		/* "exclude user" means "count only kernel" */
> > +		if (event->attr.exclude_user)
> > +			hwc->config |= ARC_REG_PCT_CONFIG_KERN;
> > +
> > +		/* "exclude kernel" means "count only user" */
> > +		if (event->attr.exclude_kernel)
> > +			hwc->config |= ARC_REG_PCT_CONFIG_USER;
> > +	}
> > +
> >  	switch (event->attr.type) {
> >  	case PERF_TYPE_HARDWARE:
> >  		if (event->attr.config >= PERF_COUNT_HW_MAX)
> >  			return -ENOENT;
> >  		if (arc_pmu->ev_hw_idx[event->attr.config] < 0)
> >  			return -ENOENT;
> > -		hwc->config = arc_pmu->ev_hw_idx[event->attr.config];
> > +		hwc->config |= arc_pmu->ev_hw_idx[event->attr.config];
> 
> So I would still very much like perf_event_attr::config to reflect the
> value you'll program into hardware.
> 
> If you want to do that weird 4 character lookup thing, use a special
> hardware event (possibly 0 if that is not a valid value), and stuff the
> 4 chars in ::config1

Ok I understand your concern here but I cannot quite understand
what do you mean saying "stuff the 4 chars in ::config1".

Could you please explain this a bit more verbose?
Is there an example of something similar I may take a look at?

-Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web