Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1209540

Re: [PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode
Date 2015-08-19 01:40 +0200
Message-ID <pYYE1-5ai-1@gated-at.bofh.it> (permalink)
References <pU8E1-57u-3@gated-at.bofh.it> <pU8E2-57u-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Aug 05, 2015 at 06:13:32PM +0300, Alexey Brodkin wrote:
> +	hwc->config = 0;
> +
> +	if (is_isa_arcv2()) {
> +		/* "exclude user" means "count only kernel" */
> +		if (event->attr.exclude_user)
> +			hwc->config |= ARC_REG_PCT_CONFIG_KERN;
> +
> +		/* "exclude kernel" means "count only user" */
> +		if (event->attr.exclude_kernel)
> +			hwc->config |= ARC_REG_PCT_CONFIG_USER;
> +	}
> +
>  	switch (event->attr.type) {
>  	case PERF_TYPE_HARDWARE:
>  		if (event->attr.config >= PERF_COUNT_HW_MAX)
>  			return -ENOENT;
>  		if (arc_pmu->ev_hw_idx[event->attr.config] < 0)
>  			return -ENOENT;
> -		hwc->config = arc_pmu->ev_hw_idx[event->attr.config];
> +		hwc->config |= arc_pmu->ev_hw_idx[event->attr.config];

So I would still very much like perf_event_attr::config to reflect the
value you'll program into hardware.

If you want to do that weird 4 character lookup thing, use a special
hardware event (possibly 0 if that is not a valid value), and stuff the
4 chars in ::config1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-08-05 17:20 +0200
  Re: [PATCH v2 6/8] ARCv2: perf: implement exclusion of event  counting in user or kernel mode Peter Zijlstra <peterz@infradead.org> - 2015-08-19 01:40 +0200
    RE: [PATCH v2 6/8] ARCv2: perf: implement exclusion of event  counting in user or kernel mode Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-08-20 13:40 +0200

csiph-web