Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209075 > unrolled thread

linux-next: build failure after merge of the gpio tree

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2015-08-18 09:00 +0200
Last post2015-08-18 15:40 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

Contents

  linux-next: build failure after merge of the gpio tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-08-18 09:00 +0200
    Re: linux-next: build failure after merge of the gpio tree Linus Walleij <linus.walleij@linaro.org> - 2015-08-18 14:10 +0200
      Re: linux-next: build failure after merge of the gpio tree Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-08-18 14:30 +0200
        Re: linux-next: build failure after merge of the gpio tree Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2015-08-18 15:40 +0200

#1209075 — linux-next: build failure after merge of the gpio tree

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2015-08-18 09:00 +0200
Subjectlinux-next: build failure after merge of the gpio tree
Message-ID<pYJ2i-6XY-5@gated-at.bofh.it>
Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/media/i2c/tc358743.c: In function 'tc358743_probe_of':
drivers/media/i2c/tc358743.c:1786:22: error: too few arguments to function 'devm_gpiod_get'
  state->reset_gpio = devm_gpiod_get(dev, "reset");
                      ^
In file included from drivers/media/i2c/tc358743.c:34:0:
include/linux/gpio/consumer.h:73:32: note: declared here
 struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
                                ^

Caused by commit

  b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")

interacting with commit

  256148246852 ("[media] tc358743: support probe from device tree")

from the v4l-dvb tree.

I have added the following fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 18 Aug 2015 16:53:21 +1000
Subject: [PATCH] [media] tc358743: fix for devm_gpiod_get API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/media/i2c/tc358743.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index fe42c9a1cb78..8f7641164d9d 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -1783,7 +1783,7 @@ static int tc358743_probe_of(struct tc358743_state *state)
 	state->pdata.ths_trailcnt = 0x2;
 	state->pdata.hstxvregcnt = 0;
 
-	state->reset_gpio = devm_gpiod_get(dev, "reset");
+	state->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_ASIS);
 	if (IS_ERR(state->reset_gpio)) {
 		dev_err(dev, "failed to get reset gpio\n");
 		ret = PTR_ERR(state->reset_gpio);
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1209224

FromLinus Walleij <linus.walleij@linaro.org>
Date2015-08-18 14:10 +0200
Message-ID<pYNSi-5HN-7@gated-at.bofh.it>
In reply to#1209075
On Tue, Aug 18, 2015 at 8:57 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Linus,
>
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/media/i2c/tc358743.c: In function 'tc358743_probe_of':
> drivers/media/i2c/tc358743.c:1786:22: error: too few arguments to function 'devm_gpiod_get'
>   state->reset_gpio = devm_gpiod_get(dev, "reset");
>                       ^
> In file included from drivers/media/i2c/tc358743.c:34:0:
> include/linux/gpio/consumer.h:73:32: note: declared here
>  struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
>                                 ^

Argh.

> I have added the following fix patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 18 Aug 2015 16:53:21 +1000
> Subject: [PATCH] [media] tc358743: fix for devm_gpiod_get API change
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/media/i2c/tc358743.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
> index fe42c9a1cb78..8f7641164d9d 100644
> --- a/drivers/media/i2c/tc358743.c
> +++ b/drivers/media/i2c/tc358743.c
> @@ -1783,7 +1783,7 @@ static int tc358743_probe_of(struct tc358743_state *state)
>         state->pdata.ths_trailcnt = 0x2;
>         state->pdata.hstxvregcnt = 0;
>
> -       state->reset_gpio = devm_gpiod_get(dev, "reset");
> +       state->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_ASIS);
>         if (IS_ERR(state->reset_gpio)) {
>                 dev_err(dev, "failed to get reset gpio\n");
>                 ret = PTR_ERR(state->reset_gpio);

This is likely the correct solution. Mauro, can you apply Stephen's
patch to your media tree?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1209232

FromUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date2015-08-18 14:30 +0200
Message-ID<pYObE-64N-39@gated-at.bofh.it>
In reply to#1209224
Hello Linus,

I forgot to add you (and also Stephen) to Cc for my slightly different
patch. You can find it at https://patchwork.linuxtv.org/patch/30908/.

I just sent you and Stephen a bounce if you want to comment.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1209255

FromMauro Carvalho Chehab <mchehab@osg.samsung.com>
Date2015-08-18 15:40 +0200
Message-ID<pYPhn-7FH-7@gated-at.bofh.it>
In reply to#1209232
Em Tue, 18 Aug 2015 14:23:26 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> escreveu:

> Hello Linus,
> 
> I forgot to add you (and also Stephen) to Cc for my slightly different
> patch. You can find it at https://patchwork.linuxtv.org/patch/30908/.
> 
> I just sent you and Stephen a bounce if you want to comment.

My plan is to either apply Stephen or Uwe version at media latter this week,
after giving some time for people to review it.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web