Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1209224

Re: linux-next: build failure after merge of the gpio tree

Show all headers | View raw

On Tue, Aug 18, 2015 at 8:57 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Linus,
>
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/media/i2c/tc358743.c: In function 'tc358743_probe_of':
> drivers/media/i2c/tc358743.c:1786:22: error: too few arguments to function 'devm_gpiod_get'
>   state->reset_gpio = devm_gpiod_get(dev, "reset");
>                       ^
> In file included from drivers/media/i2c/tc358743.c:34:0:
> include/linux/gpio/consumer.h:73:32: note: declared here
>  struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
>                                 ^

Argh.

> I have added the following fix patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 18 Aug 2015 16:53:21 +1000
> Subject: [PATCH] [media] tc358743: fix for devm_gpiod_get API change
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/media/i2c/tc358743.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
> index fe42c9a1cb78..8f7641164d9d 100644
> --- a/drivers/media/i2c/tc358743.c
> +++ b/drivers/media/i2c/tc358743.c
> @@ -1783,7 +1783,7 @@ static int tc358743_probe_of(struct tc358743_state *state)
>         state->pdata.ths_trailcnt = 0x2;
>         state->pdata.hstxvregcnt = 0;
>
> -       state->reset_gpio = devm_gpiod_get(dev, "reset");
> +       state->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_ASIS);
>         if (IS_ERR(state->reset_gpio)) {
>                 dev_err(dev, "failed to get reset gpio\n");
>                 ret = PTR_ERR(state->reset_gpio);

This is likely the correct solution. Mauro, can you apply Stephen's
patch to your media tree?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the gpio tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-08-18 09:00 +0200
  Re: linux-next: build failure after merge of the gpio tree Linus Walleij <linus.walleij@linaro.org> - 2015-08-18 14:10 +0200
    Re: linux-next: build failure after merge of the gpio tree Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-08-18 14:30 +0200
      Re: linux-next: build failure after merge of the gpio tree Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2015-08-18 15:40 +0200

csiph-web