Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1208214 > unrolled thread
| Started by | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| First post | 2015-08-16 11:20 +0200 |
| Last post | 2015-08-17 10:50 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC v5 00/26] Re-use nvram module Geert Uytterhoeven <geert@linux-m68k.org> - 2015-08-16 11:20 +0200
Re: [RFC v5 00/26] Re-use nvram module Finn Thain <fthain@telegraphics.com.au> - 2015-08-17 10:10 +0200
Re: [RFC v5 00/26] Re-use nvram module Geert Uytterhoeven <geert@linux-m68k.org> - 2015-08-17 10:30 +0200
Re: [RFC v5 00/26] Re-use nvram module Finn Thain <fthain@telegraphics.com.au> - 2015-08-17 10:50 +0200
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2015-08-16 11:20 +0200 |
| Subject | Re: [RFC v5 00/26] Re-use nvram module |
| Message-ID | <pY2gF-49R-7@gated-at.bofh.it> |
Hi Finn,
On Sat, Jul 25, 2015 at 9:45 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
> The generic NVRAM module, drivers/char/generic_nvram, implements a
> /dev/nvram misc device. It is used only by 32-bit PowerPC platforms and
> isn't generic enough to be more widely used.
[...]
Thanks!
You can add my
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
to patches 03, 04, 11, 19, 23, 24, 25, 26.
BTW, checkpatch reported a few newly-introduced whitespace errors in patches
03, 05, 16, 24, and 25.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Finn Thain <fthain@telegraphics.com.au> |
|---|---|
| Date | 2015-08-17 10:10 +0200 |
| Message-ID | <pYnEt-1sk-1@gated-at.bofh.it> |
| In reply to | #1208214 |
On Sun, 16 Aug 2015, Geert Uytterhoeven wrote:
> Hi Finn,
>
> On Sat, Jul 25, 2015 at 9:45 AM, Finn Thain <fthain@telegraphics.com.au>
> wrote:
> > The generic NVRAM module, drivers/char/generic_nvram, implements a
> > /dev/nvram misc device. It is used only by 32-bit PowerPC platforms
> > and isn't generic enough to be more widely used.
>
> [...]
>
> Thanks!
>
> You can add my
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> to patches 03, 04, 11, 19, 23, 24, 25, 26.
Thanks for reviewing.
>
> BTW, checkpatch reported a few newly-introduced whitespace errors in
> patches 03, 05, 16, 24, and 25.
I will check again, but I'm sure those are all deliberate. I examined all
the "errors" and "warnings" before submitting.
checkpatch doesn't really understand the difference between whitespace
used for indentation of statements (according to scope) and whitespace
used for alignment of terms or parameters (when line-wrapped). Any tool
that fails to make that distinction can't be depended upon to correctly
validate the elisp in Documentation/CodingStyle, for example.
--
>
> Gr{oetje,eeting}s,
>
> Geert
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2015-08-17 10:30 +0200 |
| Message-ID | <pYnXR-1P5-29@gated-at.bofh.it> |
| In reply to | #1208452 |
Hi Finn,
On Mon, Aug 17, 2015 at 10:04 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
>> BTW, checkpatch reported a few newly-introduced whitespace errors in
>> patches 03, 05, 16, 24, and 25.
>
> I will check again, but I'm sure those are all deliberate. I examined all
> the "errors" and "warnings" before submitting.
>
> checkpatch doesn't really understand the difference between whitespace
> used for indentation of statements (according to scope) and whitespace
> used for alignment of terms or parameters (when line-wrapped). Any tool
> that fails to make that distinction can't be depended upon to correctly
> validate the elisp in Documentation/CodingStyle, for example.
Checkpatch complains because you don't replace a sequence of 8 spaces
by a TAB in continuation lines.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Finn Thain <fthain@telegraphics.com.au> |
|---|---|
| Date | 2015-08-17 10:50 +0200 |
| Message-ID | <pYohc-2c4-5@gated-at.bofh.it> |
| In reply to | #1208465 |
On Mon, 17 Aug 2015, Geert Uytterhoeven wrote:
> On Mon, Aug 17, 2015 at 10:04 AM, Finn Thain
> <fthain@telegraphics.com.au> wrote:
> >> BTW, checkpatch reported a few newly-introduced whitespace errors in
> >> patches 03, 05, 16, 24, and 25.
> >
> > I will check again, but I'm sure those are all deliberate. I examined
> > all the "errors" and "warnings" before submitting.
> >
> > checkpatch doesn't really understand the difference between whitespace
> > used for indentation of statements (according to scope) and whitespace
> > used for alignment of terms or parameters (when line-wrapped). Any
> > tool that fails to make that distinction can't be depended upon to
> > correctly validate the elisp in Documentation/CodingStyle, for
> > example.
>
> Checkpatch complains because you don't replace a sequence of 8 spaces by
> a TAB in continuation lines.
Right. Were such a sequence used for indentation, a tab should be used
instead. After those tabs, spaces are needed for alignment (see elisp
example mentioned above).
But I sure wouldn't want to try to encode that distinction in regexp (as
opposed to comparing a patch with its pretty-printed version, as might be
generated by an actual C parser). So I expect some false positives from
checkpatch.
--
>
> Gr{oetje,eeting}s,
>
> Geert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web