Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208465

Re: [RFC v5 00/26] Re-use nvram module

Show all headers | View raw

Hi Finn,

On Mon, Aug 17, 2015 at 10:04 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
>> BTW, checkpatch reported a few newly-introduced whitespace errors in
>> patches 03, 05, 16, 24, and 25.
>
> I will check again, but I'm sure those are all deliberate. I examined all
> the "errors" and "warnings" before submitting.
>
> checkpatch doesn't really understand the difference between whitespace
> used for indentation of statements (according to scope) and whitespace
> used for alignment of terms or parameters (when line-wrapped). Any tool
> that fails to make that distinction can't be depended upon to correctly
> validate the elisp in Documentation/CodingStyle, for example.

Checkpatch complains because you don't replace a sequence of 8 spaces
by a TAB in continuation lines.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [RFC v5 00/26] Re-use nvram module Geert Uytterhoeven <geert@linux-m68k.org> - 2015-08-16 11:20 +0200
  Re: [RFC v5 00/26] Re-use nvram module Finn Thain <fthain@telegraphics.com.au> - 2015-08-17 10:10 +0200
    Re: [RFC v5 00/26] Re-use nvram module Geert Uytterhoeven <geert@linux-m68k.org> - 2015-08-17 10:30 +0200
      Re: [RFC v5 00/26] Re-use nvram module Finn Thain <fthain@telegraphics.com.au> - 2015-08-17 10:50 +0200

csiph-web