Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1200795 > unrolled thread

[PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl

Started byAndrea Parri <parri.andrea@gmail.com>
First post2015-08-05 16:00 +0200
Last post2015-08-12 14:50 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl Andrea Parri <parri.andrea@gmail.com> - 2015-08-05 16:00 +0200
    Re: [PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl Juri Lelli <juri.lelli@arm.com> - 2015-08-11 12:40 +0200
    [tip:sched/core] sched/deadline: Fix comment in enqueue_task_dl() tip-bot for Andrea Parri <tipbot@zytor.com> - 2015-08-12 14:50 +0200

#1200795 — [PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl

FromAndrea Parri <parri.andrea@gmail.com>
Date2015-08-05 16:00 +0200
Subject[PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl
Message-ID<pU7oD-38E-33@gated-at.bofh.it>
The flag "dl_boosted" is set by comparing *absolute* deadlines
(c.f., rt_mutex_setprio).

Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 7c17001..be2ca5e 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -953,7 +953,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
 
 	/*
 	 * Use the scheduling parameters of the top pi-waiter
-	 * task if we have one and its (relative) deadline is
+	 * task if we have one and its (absolute) deadline is
 	 * smaller than our one... OTW we keep our runtime and
 	 * deadline.
 	 */
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1205033

FromJuri Lelli <juri.lelli@arm.com>
Date2015-08-11 12:40 +0200
Message-ID<pWf8m-2uq-21@gated-at.bofh.it>
In reply to#1200795
Hi,

On 05/08/15 14:56, Andrea Parri wrote:
> The flag "dl_boosted" is set by comparing *absolute* deadlines
> (c.f., rt_mutex_setprio).
> 
> Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
> ---
>  kernel/sched/deadline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 7c17001..be2ca5e 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -953,7 +953,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
>  
>  	/*
>  	 * Use the scheduling parameters of the top pi-waiter
> -	 * task if we have one and its (relative) deadline is
> +	 * task if we have one and its (absolute) deadline is
>  	 * smaller than our one... OTW we keep our runtime and
>  	 * deadline.
>  	 */
> 

Right, thanks for spotting it.

Best,

- Juri

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1206057 — [tip:sched/core] sched/deadline: Fix comment in enqueue_task_dl()

Fromtip-bot for Andrea Parri <tipbot@zytor.com>
Date2015-08-12 14:50 +0200
Subject[tip:sched/core] sched/deadline: Fix comment in enqueue_task_dl()
Message-ID<pWDDI-4EJ-21@gated-at.bofh.it>
In reply to#1200795
Commit-ID:  ff277d4250fe715b6666219b1a3423b863418794
Gitweb:     http://git.kernel.org/tip/ff277d4250fe715b6666219b1a3423b863418794
Author:     Andrea Parri <parri.andrea@gmail.com>
AuthorDate: Wed, 5 Aug 2015 15:56:19 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 12 Aug 2015 12:06:10 +0200

sched/deadline: Fix comment in enqueue_task_dl()

The "dl_boosted" flag is set by comparing *absolute* deadlines
(c.f., rt_mutex_setprio()).

Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1438782979-9057-2-git-send-email-parri.andrea@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 82c0dd0..fc8f010 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -953,7 +953,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
 
 	/*
 	 * Use the scheduling parameters of the top pi-waiter
-	 * task if we have one and its (relative) deadline is
+	 * task if we have one and its (absolute) deadline is
 	 * smaller than our one... OTW we keep our runtime and
 	 * deadline.
 	 */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web