Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1205033

Re: [PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl

From Juri Lelli <juri.lelli@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl
Date 2015-08-11 12:40 +0200
Message-ID <pWf8m-2uq-21@gated-at.bofh.it> (permalink)
References <pU7oC-38E-25@gated-at.bofh.it> <pU7oD-38E-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi,

On 05/08/15 14:56, Andrea Parri wrote:
> The flag "dl_boosted" is set by comparing *absolute* deadlines
> (c.f., rt_mutex_setprio).
> 
> Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
> ---
>  kernel/sched/deadline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 7c17001..be2ca5e 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -953,7 +953,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
>  
>  	/*
>  	 * Use the scheduling parameters of the top pi-waiter
> -	 * task if we have one and its (relative) deadline is
> +	 * task if we have one and its (absolute) deadline is
>  	 * smaller than our one... OTW we keep our runtime and
>  	 * deadline.
>  	 */
> 

Right, thanks for spotting it.

Best,

- Juri

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl Andrea Parri <parri.andrea@gmail.com> - 2015-08-05 16:00 +0200
  Re: [PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl Juri Lelli <juri.lelli@arm.com> - 2015-08-11 12:40 +0200
  [tip:sched/core] sched/deadline: Fix comment in enqueue_task_dl() tip-bot for Andrea Parri <tipbot@zytor.com> - 2015-08-12 14:50 +0200

csiph-web