Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1206451 > unrolled thread
| Started by | Simon Horman <horms@verge.net.au> |
|---|---|
| First post | 2015-08-13 03:00 +0200 |
| Last post | 2015-08-13 22:50 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Simon Horman <horms@verge.net.au> - 2015-08-13 03:00 +0200
Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Baoquan He <bhe@redhat.com> - 2015-08-13 08:00 +0200
Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Simon Horman <horms@verge.net.au> - 2015-08-13 10:00 +0200
Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Andrew Morton <akpm@linux-foundation.org> - 2015-08-13 22:50 +0200
| From | Simon Horman <horms@verge.net.au> |
|---|---|
| Date | 2015-08-13 03:00 +0200 |
| Subject | Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic |
| Message-ID | <pWP2b-4fa-29@gated-at.bofh.it> |
On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote:
> Transforming PFN(Page Frame Number) to struct page is never failure, so
> we can simplify the code logic to do the image->control_page assignment
> directly in the loop, and remove the unnecessary conditional judgement.
>
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> Acked-by: Dave Young <dyoung@redhat.com>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
Andrew, could you consider picking this up.
It seems to have been sufficiently reviewed, acked, etc...
> ---
> kernel/kexec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 6f1ed75..cf82474 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -807,11 +807,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
> /* If I don't overlap any segments I have found my hole! */
> if (i == image->nr_segments) {
> pages = pfn_to_page(hole_start >> PAGE_SHIFT);
> + image->control_page = hole_end;
> break;
> }
> }
> - if (pages)
> - image->control_page = hole_end;
>
> return pages;
> }
> --
> 2.4.0
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Baoquan He <bhe@redhat.com> |
|---|---|
| Date | 2015-08-13 08:00 +0200 |
| Message-ID | <pWTIu-2Kb-13@gated-at.bofh.it> |
| In reply to | #1206451 |
On 08/13/15 at 09:55am, Simon Horman wrote:
> On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote:
> > Transforming PFN(Page Frame Number) to struct page is never failure, so
> > we can simplify the code logic to do the image->control_page assignment
> > directly in the loop, and remove the unnecessary conditional judgement.
> >
> > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> > Acked-by: Dave Young <dyoung@redhat.com>
> > Acked-by: Vivek Goyal <vgoyal@redhat.com>
>
> Andrew, could you consider picking this up.
> It seems to have been sufficiently reviewed, acked, etc...
I saw this has been in linux-next tree.
commit b90b6ef0f152ef42fe66ce5c9ccf2783ea84fa69
Author: Minfei Huang <mnfhuang@gmail.com>
Date: Thu Jul 30 09:56:18 2015 +1000
kexec: remove unnecessary test in kimage_alloc_crash_control_pages()
Thanks
Baoquan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Simon Horman <horms@verge.net.au> |
|---|---|
| Date | 2015-08-13 10:00 +0200 |
| Message-ID | <pWVAC-5qg-7@gated-at.bofh.it> |
| In reply to | #1206524 |
On Thu, Aug 13, 2015 at 01:53:45PM +0800, Baoquan He wrote: > On 08/13/15 at 09:55am, Simon Horman wrote: > > On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: > > > Transforming PFN(Page Frame Number) to struct page is never failure, so > > > we can simplify the code logic to do the image->control_page assignment > > > directly in the loop, and remove the unnecessary conditional judgement. > > > > > > Signed-off-by: Minfei Huang <mnfhuang@gmail.com> > > > Acked-by: Dave Young <dyoung@redhat.com> > > > Acked-by: Vivek Goyal <vgoyal@redhat.com> > > > > Andrew, could you consider picking this up. > > It seems to have been sufficiently reviewed, acked, etc... > > I saw this has been in linux-next tree. Excellent, sorry for the noise. > commit b90b6ef0f152ef42fe66ce5c9ccf2783ea84fa69 > Author: Minfei Huang <mnfhuang@gmail.com> > Date: Thu Jul 30 09:56:18 2015 +1000 > > kexec: remove unnecessary test in kimage_alloc_crash_control_pages() > > Thanks > Baoquan > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Date | 2015-08-13 22:50 +0200 |
| Message-ID | <pX7BL-62s-15@gated-at.bofh.it> |
| In reply to | #1206451 |
On Thu, 13 Aug 2015 09:55:25 +0900 Simon Horman <horms@verge.net.au> wrote: > On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: > > Transforming PFN(Page Frame Number) to struct page is never failure, so > > we can simplify the code logic to do the image->control_page assignment > > directly in the loop, and remove the unnecessary conditional judgement. > > > > Signed-off-by: Minfei Huang <mnfhuang@gmail.com> > > Acked-by: Dave Young <dyoung@redhat.com> > > Acked-by: Vivek Goyal <vgoyal@redhat.com> > > Andrew, could you consider picking this up. > It seems to have been sufficiently reviewed, acked, etc... I grabbed this one of July 28. http://ozlabs.org/~akpm/mmotm/broken-out/kexec-remove-the-unnecessary-conditional-judgement-to-simplify-the-code-logic.patch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web