Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1206451

Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

Show all headers | View raw

On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote:
> Transforming PFN(Page Frame Number) to struct page is never failure, so
> we can simplify the code logic to do the image->control_page assignment
> directly in the loop, and remove the unnecessary conditional judgement.
> 
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> Acked-by: Dave Young <dyoung@redhat.com>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>

Andrew, could you consider picking this up.
It seems to have been sufficiently reviewed, acked, etc...

> ---
>  kernel/kexec.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 6f1ed75..cf82474 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -807,11 +807,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
>  		/* If I don't overlap any segments I have found my hole! */
>  		if (i == image->nr_segments) {
>  			pages = pfn_to_page(hole_start >> PAGE_SHIFT);
> +			image->control_page = hole_end;
>  			break;
>  		}
>  	}
> -	if (pages)
> -		image->control_page = hole_end;
>  
>  	return pages;
>  }
> -- 
> 2.4.0
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [REPOST PATCH] kexec: Remove the unnecessary conditional  judgement to simplify the code logic Simon Horman <horms@verge.net.au> - 2015-08-13 03:00 +0200
  Re: [REPOST PATCH] kexec: Remove the unnecessary conditional  judgement to simplify the code logic Baoquan He <bhe@redhat.com> - 2015-08-13 08:00 +0200
    Re: [REPOST PATCH] kexec: Remove the unnecessary conditional  judgement to simplify the code logic Simon Horman <horms@verge.net.au> - 2015-08-13 10:00 +0200
  Re: [REPOST PATCH] kexec: Remove the unnecessary conditional  judgement to simplify the code logic Andrew Morton <akpm@linux-foundation.org> - 2015-08-13 22:50 +0200

csiph-web