Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1201780 > unrolled thread

Re: [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in kmem_cache_destroy()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in  kmem_cache_destroy() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-08-06 16:30 +0200
    Re: [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in  kmem_cache_destroy() Julia Lawall <julia.lawall@lip6.fr> - 2015-08-06 16:30 +0200
      Re: [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in  kmem_cache_destroy() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-08-06 16:40 +0200

#1201780 — Re: [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in kmem_cache_destroy()

On (06/19/15 08:50), Julia Lawall wrote:
> On Thu, 18 Jun 2015, Sergey Senozhatsky wrote:
> 
> > On (06/17/15 16:14), David Rientjes wrote:
> > [..]
> > > >
> > > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > > > Reported-by: Andrew Morton <akpm@linux-foundation.org>
> > > > LKML-reference: https://lkml.org/lkml/2015/6/8/583
> > >
> > > Acked-by: David Rientjes <rientjes@google.com>
> > >
> > > kmem_cache_destroy() isn't a fastpath, this is long overdue.  Now where's
> > > the patch to remove the NULL checks from the callers? ;)
> > >
> >
> > Thanks.
> >
> > Yes, Julia Lawall (Cc'd) already has a patch set ready for submission.
> 
> I'll refresh it and send it shortly.
> 

I'll re-up this thread.

Julia, do you want to wait until these 3 patches will be merged to
Linus's tree (just to be on a safe side, so someone's tree (out of sync
with linux-next) will not go crazy)?

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1201799

On Thu, 6 Aug 2015, Sergey Senozhatsky wrote:

> On (06/19/15 08:50), Julia Lawall wrote:
> > On Thu, 18 Jun 2015, Sergey Senozhatsky wrote:
> >
> > > On (06/17/15 16:14), David Rientjes wrote:
> > > [..]
> > > > >
> > > > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > > > > Reported-by: Andrew Morton <akpm@linux-foundation.org>
> > > > > LKML-reference: https://lkml.org/lkml/2015/6/8/583
> > > >
> > > > Acked-by: David Rientjes <rientjes@google.com>
> > > >
> > > > kmem_cache_destroy() isn't a fastpath, this is long overdue.  Now where's
> > > > the patch to remove the NULL checks from the callers? ;)
> > > >
> > >
> > > Thanks.
> > >
> > > Yes, Julia Lawall (Cc'd) already has a patch set ready for submission.
> >
> > I'll refresh it and send it shortly.
> >
>
> I'll re-up this thread.
>
> Julia, do you want to wait until these 3 patches will be merged to
> Linus's tree (just to be on a safe side, so someone's tree (out of sync
> with linux-next) will not go crazy)?

I think it would be safer.  Code may crash if the test is removed before
the function can tolerate it.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1201813

On (08/06/15 16:27), Julia Lawall wrote:
[..]
> > Julia, do you want to wait until these 3 patches will be merged to
> > Linus's tree (just to be on a safe side, so someone's tree (out of sync
> > with linux-next) will not go crazy)?
> 
> I think it would be safer.  Code may crash if the test is removed before
> the function can tolerate it.
> 

Agree. I'll re-up this thread later (once 4.3 merge window is closed).
Thank you.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web