Groups > linux.kernel > #1201799

Re: [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in kmem_cache_destroy()

From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in kmem_cache_destroy()
Date	2015-08-06 16:30 +0200
Message-ID	<pUuld-367-43@gated-at.bofh.it> (permalink)
References	(1 earlier) <pzqvU-682-23@gated-at.bofh.it> <pCuMI-7y2-77@gated-at.bofh.it> <pCvpo-8ib-13@gated-at.bofh.it> <pD6RY-3rz-9@gated-at.bofh.it> <pUulb-367-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Thu, 6 Aug 2015, Sergey Senozhatsky wrote:

> On (06/19/15 08:50), Julia Lawall wrote:
> > On Thu, 18 Jun 2015, Sergey Senozhatsky wrote:
> >
> > > On (06/17/15 16:14), David Rientjes wrote:
> > > [..]
> > > > >
> > > > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > > > > Reported-by: Andrew Morton <akpm@linux-foundation.org>
> > > > > LKML-reference: https://lkml.org/lkml/2015/6/8/583
> > > >
> > > > Acked-by: David Rientjes <rientjes@google.com>
> > > >
> > > > kmem_cache_destroy() isn't a fastpath, this is long overdue.  Now where's
> > > > the patch to remove the NULL checks from the callers? ;)
> > > >
> > >
> > > Thanks.
> > >
> > > Yes, Julia Lawall (Cc'd) already has a patch set ready for submission.
> >
> > I'll refresh it and send it shortly.
> >
>
> I'll re-up this thread.
>
> Julia, do you want to wait until these 3 patches will be merged to
> Linus's tree (just to be on a safe side, so someone's tree (out of sync
> with linux-next) will not go crazy)?

I think it would be safer.  Code may crash if the test is removed before
the function can tolerate it.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in  kmem_cache_destroy() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-08-06 16:30 +0200
  Re: [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in  kmem_cache_destroy() Julia Lawall <julia.lawall@lip6.fr> - 2015-08-06 16:30 +0200
    Re: [RFC][PATCH 1/5] mm/slab_common: allow NULL cache pointer in  kmem_cache_destroy() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-08-06 16:40 +0200

csiph-web