Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1201415 > unrolled thread
| Started by | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| First post | 2015-08-06 05:50 +0200 |
| Last post | 2015-08-06 08:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] checkpatch: Don't complain about long "Fixes:" lines Michael Ellerman <mpe@ellerman.id.au> - 2015-08-06 05:50 +0200
Re: [PATCH] checkpatch: Don't complain about long "Fixes:" lines Joe Perches <joe@perches.com> - 2015-08-06 06:00 +0200
Re: [PATCH] checkpatch: Don't complain about long "Fixes:" lines Michael Ellerman <mpe@ellerman.id.au> - 2015-08-06 08:30 +0200
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Date | 2015-08-06 05:50 +0200 |
| Subject | [PATCH] checkpatch: Don't complain about long "Fixes:" lines |
| Message-ID | <pUklP-54X-13@gated-at.bofh.it> |
We encourage people to mention the commit they are fixing, if any, using
a Fixes line, see SubmittingPatches.
Although it's not mentioned explicitly, it's preferable if the Fixes
line is not wrapped, so skip Fixes lines when checking for overlength
lines.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d5c8e9a3a73c..b3139cb1bf9d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2310,7 +2310,7 @@ sub process {
# Check for line lengths > 75 in commit log, warn once
if ($in_commit_log && !$commit_log_long_line &&
- length($line) > 75) {
+ length($line) > 75 && $line !~ /^\s*Fixes: [0-9a-f]+/i) {
WARN("COMMIT_LOG_LONG_LINE",
"Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
$commit_log_long_line = 1;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2015-08-06 06:00 +0200 |
| Message-ID | <pUkvv-5g6-1@gated-at.bofh.it> |
| In reply to | #1201415 |
On Thu, 2015-08-06 at 13:44 +1000, Michael Ellerman wrote: > We encourage people to mention the commit they are fixing, if any, using > a Fixes line, see SubmittingPatches. https://lkml.org/lkml/2015/7/31/1271 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Date | 2015-08-06 08:30 +0200 |
| Message-ID | <pUmQG-E0-21@gated-at.bofh.it> |
| In reply to | #1201417 |
On Wed, 2015-08-05 at 20:50 -0700, Joe Perches wrote: > On Thu, 2015-08-06 at 13:44 +1000, Michael Ellerman wrote: > > We encourage people to mention the commit they are fixing, if any, using > > a Fixes line, see SubmittingPatches. > > https://lkml.org/lkml/2015/7/31/1271 Thanks. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web