Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1201415

[PATCH] checkpatch: Don't complain about long "Fixes:" lines

Show all headers | View raw

We encourage people to mention the commit they are fixing, if any, using
a Fixes line, see SubmittingPatches.

Although it's not mentioned explicitly, it's preferable if the Fixes
line is not wrapped, so skip Fixes lines when checking for overlength
lines.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d5c8e9a3a73c..b3139cb1bf9d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2310,7 +2310,7 @@ sub process {
 
 # Check for line lengths > 75 in commit log, warn once
 		if ($in_commit_log && !$commit_log_long_line &&
-		    length($line) > 75) {
+		    length($line) > 75 && $line !~ /^\s*Fixes: [0-9a-f]+/i) {
 			WARN("COMMIT_LOG_LONG_LINE",
 			     "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
 			$commit_log_long_line = 1;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] checkpatch: Don't complain about long "Fixes:" lines Michael Ellerman <mpe@ellerman.id.au> - 2015-08-06 05:50 +0200
  Re: [PATCH] checkpatch: Don't complain about long "Fixes:" lines Joe Perches <joe@perches.com> - 2015-08-06 06:00 +0200
    Re: [PATCH] checkpatch: Don't complain about long "Fixes:" lines Michael Ellerman <mpe@ellerman.id.au> - 2015-08-06 08:30 +0200

csiph-web