Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1198489 > unrolled thread
| Started by | <fupan.li@windriver.com> |
|---|---|
| First post | 2015-08-03 04:10 +0200 |
| Last post | 2015-08-04 00:20 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH V2] efi: fix 32bit kernel boot failed problem using efi <fupan.li@windriver.com> - 2015-08-03 04:10 +0200
Re: [PATCH V2] efi: fix 32bit kernel boot failed problem using efi Matt Fleming <matt@codeblueprint.co.uk> - 2015-08-03 13:50 +0200
Re: [PATCH V2] efi: fix 32bit kernel boot failed problem using efi Greg KH <gregkh@linuxfoundation.org> - 2015-08-03 18:20 +0200
Re: [PATCH V2] efi: fix 32bit kernel boot failed problem using efi Ben Hutchings <ben@decadent.org.uk> - 2015-08-04 00:20 +0200
| From | <fupan.li@windriver.com> |
|---|---|
| Date | 2015-08-03 04:10 +0200 |
| Subject | [PATCH V2] efi: fix 32bit kernel boot failed problem using efi |
| Message-ID | <pTdmq-5xR-5@gated-at.bofh.it> |
From: fli <fupan.li@windriver.com>
Commit 35d5134b7d5a
("x86/efi: Correct EFI boot stub use of code32_start")
imported a bug, which will cause 32bit kernel boot failed
using efi method. It should use the label's address instead
of the value stored in the label to caculate the address of
code32_start.
Signed-off-by: Fupan Li <fupan.li@windriver.com>
---
arch/x86/boot/compressed/head_32.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/compressed/head_32.S b/arch/x86/boot/compressed/head_32.S
index abb988a..3b28eff 100644
--- a/arch/x86/boot/compressed/head_32.S
+++ b/arch/x86/boot/compressed/head_32.S
@@ -54,7 +54,7 @@ ENTRY(efi_pe_entry)
call reloc
reloc:
popl %ecx
- subl reloc, %ecx
+ subl $reloc, %ecx
movl %ecx, BP_code32_start(%eax)
sub $0x4, %esp
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Matt Fleming <matt@codeblueprint.co.uk> |
|---|---|
| Date | 2015-08-03 13:50 +0200 |
| Message-ID | <pTmpH-1Yc-3@gated-at.bofh.it> |
| In reply to | #1198489 |
On Mon, 03 Aug, at 10:02:49AM, fupan.li@windriver.com wrote:
> From: fli <fupan.li@windriver.com>
>
> Commit 35d5134b7d5a
> ("x86/efi: Correct EFI boot stub use of code32_start")
> imported a bug, which will cause 32bit kernel boot failed
> using efi method. It should use the label's address instead
> of the value stored in the label to caculate the address of
> code32_start.
>
> Signed-off-by: Fupan Li <fupan.li@windriver.com>
> ---
> arch/x86/boot/compressed/head_32.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Matt Fleming <matt.fleming@intel.com>
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-08-03 18:20 +0200 |
| Message-ID | <pTqD0-8cj-15@gated-at.bofh.it> |
| In reply to | #1198489 |
On Mon, Aug 03, 2015 at 10:02:49AM +0800, fupan.li@windriver.com wrote: > From: fli <fupan.li@windriver.com> This needs to match the signed-off-by line, otherwise I can't take it :( Please fix up and resend. And what -stable tree is this for? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| Date | 2015-08-04 00:20 +0200 |
| Message-ID | <pTwfn-81h-13@gated-at.bofh.it> |
| In reply to | #1199007 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, 2015-08-03 at 09:15 -0700, Greg KH wrote: > On Mon, Aug 03, 2015 at 10:02:49AM +0800, fupan.li@windriver.com wrot > e: > > From: fli <fupan.li@windriver.com> > > This needs to match the signed-off-by line, otherwise I can't take it > :( > > Please fix up and resend. > > And what -stable tree is this for? The bug was introduced in 35d5134b7d5a on the 3.10 branch, but the same bug in the backport seems to have been introduced on the 3.14 branch and two others you don't maintain: v3.10.39: 35d5134b7d5a x86/efi: Correct EFI boot stub use of code32_start v3.12.20: 065487a10a22 x86/efi: Correct EFI boot stub use of code32_start v3.14.3: 45ada9fae6d8 x86/efi: Correct EFI boot stub use of code32_start v3.11.10.11: f32e88d764e3 x86/efi: Correct EFI boot stub use of code32_start Ben. -- Ben Hutchings Unix is many things to many people, but it's never been everything to anybody.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web