Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1198489

[PATCH V2] efi: fix 32bit kernel boot failed problem using efi

Show all headers | View raw

From: fli <fupan.li@windriver.com>

Commit 35d5134b7d5a
("x86/efi: Correct EFI boot stub use of code32_start")
imported a bug, which will cause 32bit kernel boot failed
using efi method. It should use the label's address instead
of the value stored in the label to caculate the address of
code32_start.

Signed-off-by: Fupan Li <fupan.li@windriver.com>
---
 arch/x86/boot/compressed/head_32.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/compressed/head_32.S b/arch/x86/boot/compressed/head_32.S
index abb988a..3b28eff 100644
--- a/arch/x86/boot/compressed/head_32.S
+++ b/arch/x86/boot/compressed/head_32.S
@@ -54,7 +54,7 @@ ENTRY(efi_pe_entry)
 	call	reloc
 reloc:
 	popl	%ecx
-	subl	reloc, %ecx
+	subl	$reloc, %ecx
 	movl	%ecx, BP_code32_start(%eax)
 
 	sub	$0x4, %esp
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH V2] efi: fix 32bit kernel boot failed problem using efi <fupan.li@windriver.com> - 2015-08-03 04:10 +0200
  Re: [PATCH V2] efi: fix 32bit kernel boot failed problem using efi Matt Fleming <matt@codeblueprint.co.uk> - 2015-08-03 13:50 +0200
  Re: [PATCH V2] efi: fix 32bit kernel boot failed problem using efi Greg KH <gregkh@linuxfoundation.org> - 2015-08-03 18:20 +0200
    Re: [PATCH V2] efi: fix 32bit kernel boot failed problem using efi Ben Hutchings <ben@decadent.org.uk> - 2015-08-04 00:20 +0200

csiph-web