Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1198417 > unrolled thread
| Started by | Joe Perches <joe@perches.com> |
|---|---|
| First post | 2015-08-02 22:30 +0200 |
| Last post | 2015-08-03 17:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal> Joe Perches <joe@perches.com> - 2015-08-02 22:30 +0200
Re: [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal> Dimitri Sivanich <sivanich@sgi.com> - 2015-08-03 15:20 +0200
Re: [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal> Joe Perches <joe@perches.com> - 2015-08-03 17:30 +0200
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2015-08-02 22:30 +0200 |
| Subject | [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal> |
| Message-ID | <pT83o-6i0-11@gated-at.bofh.it> |
Correct misuse of 0x%d in logging message.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/misc/sgi-gru/grumain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
index ae16c8c..a1ce324 100644
--- a/drivers/misc/sgi-gru/grumain.c
+++ b/drivers/misc/sgi-gru/grumain.c
@@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
spin_lock(&gru->gs_asid_lock);
BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
asids->mt_ctxbitmap ^= ctxbitmap;
- gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
+ gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
spin_unlock(&gru->gs_asid_lock);
spin_unlock(&gms->ms_asid_lock);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Dimitri Sivanich <sivanich@sgi.com> |
|---|---|
| Date | 2015-08-03 15:20 +0200 |
| Message-ID | <pTnOO-48k-13@gated-at.bofh.it> |
| In reply to | #1198417 |
This should be %d, not 0x%x. Nacked-by: Dimitri Sivanich <sivanich@sgi.com> On Sun, Aug 02, 2015 at 01:27:27PM -0700, Joe Perches wrote: > Correct misuse of 0x%d in logging message. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/misc/sgi-gru/grumain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c > index ae16c8c..a1ce324 100644 > --- a/drivers/misc/sgi-gru/grumain.c > +++ b/drivers/misc/sgi-gru/grumain.c > @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru, > spin_lock(&gru->gs_asid_lock); > BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap); > asids->mt_ctxbitmap ^= ctxbitmap; > - gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n", > + gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n", > gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]); > spin_unlock(&gru->gs_asid_lock); > spin_unlock(&gms->ms_asid_lock); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2015-08-03 17:30 +0200 |
| Message-ID | <pTpQE-71w-59@gated-at.bofh.it> |
| In reply to | #1198846 |
On Mon, 2015-08-03 at 08:10 -0500, Dimitri Sivanich wrote: > This should be %d, not 0x%x. I don't care one way or the other, but please fix it so it matches. > > diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c > > index ae16c8c..a1ce324 100644 > > --- a/drivers/misc/sgi-gru/grumain.c > > +++ b/drivers/misc/sgi-gru/grumain.c > > @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru, > > spin_lock(&gru->gs_asid_lock); > > BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap); > > asids->mt_ctxbitmap ^= ctxbitmap; > > - gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n", > > + gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n", > > gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]); > > spin_unlock(&gru->gs_asid_lock); > > spin_unlock(&gms->ms_asid_lock); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web