Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1198957

Re: [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal>

Show all headers | View raw

On Mon, 2015-08-03 at 08:10 -0500, Dimitri Sivanich wrote:
> This should be %d, not 0x%x.

I don't care one way or the other, but
please fix it so it matches.


> > diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
> > index ae16c8c..a1ce324 100644
> > --- a/drivers/misc/sgi-gru/grumain.c
> > +++ b/drivers/misc/sgi-gru/grumain.c
> > @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
> >         spin_lock(&gru->gs_asid_lock);
> >         BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
> >         asids->mt_ctxbitmap ^= ctxbitmap;
> > -       gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
> > +       gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
> >                 gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
> >         spin_unlock(&gru->gs_asid_lock);
> >         spin_unlock(&gms->ms_asid_lock);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal> Joe Perches <joe@perches.com> - 2015-08-02 22:30 +0200
  Re: [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal> Dimitri Sivanich <sivanich@sgi.com> - 2015-08-03 15:20 +0200
    Re: [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal> Joe Perches <joe@perches.com> - 2015-08-03 17:30 +0200

csiph-web