Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1198499 > unrolled thread

[PATCH V2] iio: declare struct to fix warning

Started byPengyu Ma <pengyu.ma@windriver.com>
First post2015-08-03 04:40 +0200
Last post2015-08-04 10:20 +0200
Articles 9 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH V2] iio: declare struct to fix warning Pengyu Ma <pengyu.ma@windriver.com> - 2015-08-03 04:40 +0200
    Re: [PATCH V2] iio: declare struct to fix warning Pengyu Ma <pengyu.ma@windriver.com> - 2015-08-04 10:00 +0200
      Re: [PATCH V2] iio: declare struct to fix warning Lars-Peter Clausen <lars@metafoo.de> - 2015-08-04 10:00 +0200
        Re: [PATCH V2] iio: declare struct to fix warning Crt Mori <cmo@melexis.com> - 2015-08-04 10:00 +0200
        Re: [PATCH V2] iio: declare struct to fix warning Pengyu Ma <pengyu.ma@windriver.com> - 2015-08-04 10:00 +0200
          Re: [PATCH V2] iio: declare struct to fix warning Lars-Peter Clausen <lars@metafoo.de> - 2015-08-04 10:10 +0200
    Re: [PATCH V2] iio: declare struct to fix warning Daniel Baluta <daniel.baluta@gmail.com> - 2015-08-04 10:10 +0200
      Re: [PATCH V2] iio: declare struct to fix warning Pengyu Ma <pengyu.ma@windriver.com> - 2015-08-04 10:20 +0200
        Re: [PATCH V2] iio: declare struct to fix warning Daniel Baluta <daniel.baluta@gmail.com> - 2015-08-04 10:20 +0200

#1198499 — [PATCH V2] iio: declare struct to fix warning

FromPengyu Ma <pengyu.ma@windriver.com>
Date2015-08-03 04:40 +0200
Subject[PATCH V2] iio: declare struct to fix warning
Message-ID<pTdPr-6bY-7@gated-at.bofh.it>
When compile iio related driver the following warning shown:

include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
declared inside parameter list
  int (*set_trigger_state)(struct iio_trigger *trig, bool state);

include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
declared inside parameter list
           struct iio_dev *indio_dev);

'struct iio_dev' and 'struct iio_trigger' was used before declaration,
forward declaration for these structs to fix warning.

Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
---
 include/linux/iio/trigger.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
index fa76c79..974cf73 100644
--- a/include/linux/iio/trigger.h
+++ b/include/linux/iio/trigger.h
@@ -18,6 +18,10 @@ struct iio_subirq {
 	bool enabled;
 };
 
+/* forward declaration */
+struct iio_dev;
+struct iio_trigger;
+
 /**
  * struct iio_trigger_ops - operations structure for an iio_trigger.
  * @owner:		used to monitor usage count of the trigger.
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1199491

FromPengyu Ma <pengyu.ma@windriver.com>
Date2015-08-04 10:00 +0200
Message-ID<pTFiF-4dp-3@gated-at.bofh.it>
In reply to#1198499
If this patch is fine, could somebody help me to merge into upstream kernel?

Thanks,
Pengyu

On 08/03/2015 10:39 AM, Pengyu Ma wrote:
> When compile iio related driver the following warning shown:
>
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
>    int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
>             struct iio_dev *indio_dev);
>
> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
> forward declaration for these structs to fix warning.
>
> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
> ---
>   include/linux/iio/trigger.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index fa76c79..974cf73 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -18,6 +18,10 @@ struct iio_subirq {
>   	bool enabled;
>   };
>   
> +/* forward declaration */
> +struct iio_dev;
> +struct iio_trigger;
> +
>   /**
>    * struct iio_trigger_ops - operations structure for an iio_trigger.
>    * @owner:		used to monitor usage count of the trigger.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1199493

FromLars-Peter Clausen <lars@metafoo.de>
Date2015-08-04 10:00 +0200
Message-ID<pTFiF-4dp-5@gated-at.bofh.it>
In reply to#1199491
On 08/04/2015 09:52 AM, Pengyu Ma wrote:
> If this patch is fine, could somebody help me to merge into upstream kernel?

It will be merged, don't worry. But things typically take a bit longer than
just a single day.

> 
> Thanks,
> Pengyu
> 
> On 08/03/2015 10:39 AM, Pengyu Ma wrote:
>> When compile iio related driver the following warning shown:
>>
>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>> declared inside parameter list
>>    int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>
>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>> declared inside parameter list
>>             struct iio_dev *indio_dev);
>>
>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>> forward declaration for these structs to fix warning.
>>
>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>> ---
>>   include/linux/iio/trigger.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>> index fa76c79..974cf73 100644
>> --- a/include/linux/iio/trigger.h
>> +++ b/include/linux/iio/trigger.h
>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>       bool enabled;
>>   };
>>   +/* forward declaration */
>> +struct iio_dev;
>> +struct iio_trigger;
>> +
>>   /**
>>    * struct iio_trigger_ops - operations structure for an iio_trigger.
>>    * @owner:        used to monitor usage count of the trigger.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1199496

FromCrt Mori <cmo@melexis.com>
Date2015-08-04 10:00 +0200
Message-ID<pTFiG-4dp-21@gated-at.bofh.it>
In reply to#1199493
On 4 August 2015 at 09:56, Pengyu Ma <pengyu.ma@windriver.com> wrote:
>
>
> On 08/04/2015 03:54 PM, Lars-Peter Clausen wrote:
>>
>> On 08/04/2015 09:52 AM, Pengyu Ma wrote:
>>>
>>> If this patch is fine, could somebody help me to merge into upstream
>>> kernel?
>>
>> It will be merged, don't worry. But things typically take a bit longer
>> than
>> just a single day.
>
> So it's will be merge by patch, no need a pull-request, right?
Correct.
>
> Thanks,
> Pengyu
>
>>> Thanks,
>>> Pengyu
>>>
>>> On 08/03/2015 10:39 AM, Pengyu Ma wrote:
>>>>
>>>> When compile iio related driver the following warning shown:
>>>>
>>>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>>>> declared inside parameter list
>>>>     int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>>>
>>>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>>>> declared inside parameter list
>>>>              struct iio_dev *indio_dev);
>>>>
>>>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>>>> forward declaration for these structs to fix warning.
>>>>
>>>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>>>> ---
>>>>    include/linux/iio/trigger.h | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>>>> index fa76c79..974cf73 100644
>>>> --- a/include/linux/iio/trigger.h
>>>> +++ b/include/linux/iio/trigger.h
>>>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>>>        bool enabled;
>>>>    };
>>>>    +/* forward declaration */
>>>> +struct iio_dev;
>>>> +struct iio_trigger;
>>>> +
>>>>    /**
>>>>     * struct iio_trigger_ops - operations structure for an iio_trigger.
>>>>     * @owner:        used to monitor usage count of the trigger.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1199497

FromPengyu Ma <pengyu.ma@windriver.com>
Date2015-08-04 10:00 +0200
Message-ID<pTFiF-4dp-11@gated-at.bofh.it>
In reply to#1199493

On 08/04/2015 03:54 PM, Lars-Peter Clausen wrote:
> On 08/04/2015 09:52 AM, Pengyu Ma wrote:
>> If this patch is fine, could somebody help me to merge into upstream kernel?
> It will be merged, don't worry. But things typically take a bit longer than
> just a single day.
So it's will be merge by patch, no need a pull-request, right?

Thanks,
Pengyu
>> Thanks,
>> Pengyu
>>
>> On 08/03/2015 10:39 AM, Pengyu Ma wrote:
>>> When compile iio related driver the following warning shown:
>>>
>>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>>> declared inside parameter list
>>>     int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>>
>>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>>> declared inside parameter list
>>>              struct iio_dev *indio_dev);
>>>
>>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>>> forward declaration for these structs to fix warning.
>>>
>>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>>> ---
>>>    include/linux/iio/trigger.h | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>>> index fa76c79..974cf73 100644
>>> --- a/include/linux/iio/trigger.h
>>> +++ b/include/linux/iio/trigger.h
>>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>>        bool enabled;
>>>    };
>>>    +/* forward declaration */
>>> +struct iio_dev;
>>> +struct iio_trigger;
>>> +
>>>    /**
>>>     * struct iio_trigger_ops - operations structure for an iio_trigger.
>>>     * @owner:        used to monitor usage count of the trigger.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1199499

FromLars-Peter Clausen <lars@metafoo.de>
Date2015-08-04 10:10 +0200
Message-ID<pTFsm-4Ef-1@gated-at.bofh.it>
In reply to#1199497
On 08/04/2015 09:56 AM, Pengyu Ma wrote:
> 
> 
> On 08/04/2015 03:54 PM, Lars-Peter Clausen wrote:
>> On 08/04/2015 09:52 AM, Pengyu Ma wrote:
>>> If this patch is fine, could somebody help me to merge into upstream kernel?
>> It will be merged, don't worry. But things typically take a bit longer than
>> just a single day.
> So it's will be merge by patch, no need a pull-request, right?

Yes, Jonathan will pick it up and apply it to the IIO tree.

Thanks for the patch.

> 
> Thanks,
> Pengyu
>>> Thanks,
>>> Pengyu
>>>
>>> On 08/03/2015 10:39 AM, Pengyu Ma wrote:
>>>> When compile iio related driver the following warning shown:
>>>>
>>>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>>>> declared inside parameter list
>>>>     int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>>>
>>>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>>>> declared inside parameter list
>>>>              struct iio_dev *indio_dev);
>>>>
>>>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>>>> forward declaration for these structs to fix warning.
>>>>
>>>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>>>> ---
>>>>    include/linux/iio/trigger.h | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>>>> index fa76c79..974cf73 100644
>>>> --- a/include/linux/iio/trigger.h
>>>> +++ b/include/linux/iio/trigger.h
>>>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>>>        bool enabled;
>>>>    };
>>>>    +/* forward declaration */
>>>> +struct iio_dev;
>>>> +struct iio_trigger;
>>>> +
>>>>    /**
>>>>     * struct iio_trigger_ops - operations structure for an iio_trigger.
>>>>     * @owner:        used to monitor usage count of the trigger.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1199501

FromDaniel Baluta <daniel.baluta@gmail.com>
Date2015-08-04 10:10 +0200
Message-ID<pTFsm-4Ef-11@gated-at.bofh.it>
In reply to#1198499
On Mon, Aug 3, 2015 at 5:39 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
> When compile iio related driver the following warning shown:
>
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
>   int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
>            struct iio_dev *indio_dev);
>
> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
> forward declaration for these structs to fix warning.
>
> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
> ---
>  include/linux/iio/trigger.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index fa76c79..974cf73 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -18,6 +18,10 @@ struct iio_subirq {
>         bool enabled;
>  };
>
> +/* forward declaration */
I would remove this comment. It doesn't says much.

> +struct iio_dev;
> +struct iio_trigger;
> +
>  /**
>   * struct iio_trigger_ops - operations structure for an iio_trigger.
>   * @owner:             used to monitor usage count of the trigger.

thanks,
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1199505

FromPengyu Ma <pengyu.ma@windriver.com>
Date2015-08-04 10:20 +0200
Message-ID<pTFC1-4PP-9@gated-at.bofh.it>
In reply to#1199501

On 08/04/2015 04:03 PM, Daniel Baluta wrote:
> On Mon, Aug 3, 2015 at 5:39 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
>> When compile iio related driver the following warning shown:
>>
>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>> declared inside parameter list
>>    int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>
>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>> declared inside parameter list
>>             struct iio_dev *indio_dev);
>>
>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>> forward declaration for these structs to fix warning.
>>
>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>> ---
>>   include/linux/iio/trigger.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>> index fa76c79..974cf73 100644
>> --- a/include/linux/iio/trigger.h
>> +++ b/include/linux/iio/trigger.h
>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>          bool enabled;
>>   };
>>
>> +/* forward declaration */
> I would remove this comment. It doesn't says much.
OK, Do I need a v3 review or you apply it with your modification directly?

Pengyu
>
>> +struct iio_dev;
>> +struct iio_trigger;
>> +
>>   /**
>>    * struct iio_trigger_ops - operations structure for an iio_trigger.
>>    * @owner:             used to monitor usage count of the trigger.
> thanks,
> Daniel.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1199511

FromDaniel Baluta <daniel.baluta@gmail.com>
Date2015-08-04 10:20 +0200
Message-ID<pTFC2-4PP-21@gated-at.bofh.it>
In reply to#1199505
On Tue, Aug 4, 2015 at 11:11 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
>
>
> On 08/04/2015 04:03 PM, Daniel Baluta wrote:
>>
>> On Mon, Aug 3, 2015 at 5:39 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
>>>
>>> When compile iio related driver the following warning shown:
>>>
>>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>>> declared inside parameter list
>>>    int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>>
>>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>>> declared inside parameter list
>>>             struct iio_dev *indio_dev);
>>>
>>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>>> forward declaration for these structs to fix warning.
>>>
>>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>>> ---
>>>   include/linux/iio/trigger.h | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>>> index fa76c79..974cf73 100644
>>> --- a/include/linux/iio/trigger.h
>>> +++ b/include/linux/iio/trigger.h
>>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>>          bool enabled;
>>>   };
>>>
>>> +/* forward declaration */
>>
>> I would remove this comment. It doesn't says much.
>
> OK, Do I need a v3 review or you apply it with your modification directly?

Please send v3, Jonathan will appreciate this :).

thanks,
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web