Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199505

Re: [PATCH V2] iio: declare struct to fix warning

Show all headers | View raw

On 08/04/2015 04:03 PM, Daniel Baluta wrote:
> On Mon, Aug 3, 2015 at 5:39 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
>> When compile iio related driver the following warning shown:
>>
>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>> declared inside parameter list
>>    int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>
>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>> declared inside parameter list
>>             struct iio_dev *indio_dev);
>>
>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>> forward declaration for these structs to fix warning.
>>
>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
>> ---
>>   include/linux/iio/trigger.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>> index fa76c79..974cf73 100644
>> --- a/include/linux/iio/trigger.h
>> +++ b/include/linux/iio/trigger.h
>> @@ -18,6 +18,10 @@ struct iio_subirq {
>>          bool enabled;
>>   };
>>
>> +/* forward declaration */
> I would remove this comment. It doesn't says much.
OK, Do I need a v3 review or you apply it with your modification directly?

Pengyu
>
>> +struct iio_dev;
>> +struct iio_trigger;
>> +
>>   /**
>>    * struct iio_trigger_ops - operations structure for an iio_trigger.
>>    * @owner:             used to monitor usage count of the trigger.
> thanks,
> Daniel.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2] iio: declare struct to fix warning Pengyu Ma <pengyu.ma@windriver.com> - 2015-08-03 04:40 +0200
  Re: [PATCH V2] iio: declare struct to fix warning Pengyu Ma <pengyu.ma@windriver.com> - 2015-08-04 10:00 +0200
    Re: [PATCH V2] iio: declare struct to fix warning Lars-Peter Clausen <lars@metafoo.de> - 2015-08-04 10:00 +0200
      Re: [PATCH V2] iio: declare struct to fix warning Crt Mori <cmo@melexis.com> - 2015-08-04 10:00 +0200
      Re: [PATCH V2] iio: declare struct to fix warning Pengyu Ma <pengyu.ma@windriver.com> - 2015-08-04 10:00 +0200
        Re: [PATCH V2] iio: declare struct to fix warning Lars-Peter Clausen <lars@metafoo.de> - 2015-08-04 10:10 +0200
  Re: [PATCH V2] iio: declare struct to fix warning Daniel Baluta <daniel.baluta@gmail.com> - 2015-08-04 10:10 +0200
    Re: [PATCH V2] iio: declare struct to fix warning Pengyu Ma <pengyu.ma@windriver.com> - 2015-08-04 10:20 +0200
      Re: [PATCH V2] iio: declare struct to fix warning Daniel Baluta <daniel.baluta@gmail.com> - 2015-08-04 10:20 +0200
        Re: [PATCH V2] iio: declare struct to fix warning Jonathan Cameron <jic23@kernel.org> - 2015-08-08 13:30 +0200

csiph-web