Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1193990 > unrolled thread
| Started by | Jignesh R Patel <jigneshpatel0103@gmail.com> |
|---|---|
| First post | 2015-07-28 12:00 +0200 |
| Last post | 2015-07-28 12:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem Jignesh R Patel <jigneshpatel0103@gmail.com> - 2015-07-28 12:00 +0200
Re: [PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem Dan Carpenter <dan.carpenter@oracle.com> - 2015-07-28 12:20 +0200
| From | Jignesh R Patel <jigneshpatel0103@gmail.com> |
|---|---|
| Date | 2015-07-28 12:00 +0200 |
| Subject | [PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem |
| Message-ID | <pR9Q0-5AL-75@gated-at.bofh.it> |
From: Jignesh R Patel <jigneshpatel0103@gmail.com> This patch fix coding style problem of more then 80 character in one line. This patch does not change any logic. Signed-off-by: Jignesh R Patel <jigneshpatel0103@gmail.com> --- drivers/staging/android/ion/ion_cma_heap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c index 86b91fd..4a9a7bd 100644 --- a/drivers/staging/android/ion/ion_cma_heap.c +++ b/drivers/staging/android/ion/ion_cma_heap.c @@ -73,7 +73,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer, if (!info->table) goto free_mem; - if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len)) + if (dma_get_sgtable(dev, info->table, info->cpu_addr, + info->handle, len)) goto free_table; /* keep this for memory release */ buffer->priv_virt = info; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2015-07-28 12:20 +0200 |
| Subject | Re: [PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem |
| Message-ID | <pRa9m-6eh-83@gated-at.bofh.it> |
| In reply to | #1193990 |
The subject isn't right. You aren't patch checkpatch.pl itself you're patching android. The version doesn't go in the subject. The subject is too vague. On Tue, Jul 28, 2015 at 03:28:33PM +0530, Jignesh R Patel wrote: > From: Jignesh R Patel <jigneshpatel0103@gmail.com> Not needed. > > This patch fix coding style problem of more then > 80 character in one line. This patch does not change any > logic. > > Signed-off-by: Jignesh R Patel <jigneshpatel0103@gmail.com> > --- > drivers/staging/android/ion/ion_cma_heap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c > index 86b91fd..4a9a7bd 100644 > --- a/drivers/staging/android/ion/ion_cma_heap.c > +++ b/drivers/staging/android/ion/ion_cma_heap.c > @@ -73,7 +73,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer, > if (!info->table) > goto free_mem; > > - if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len)) > + if (dma_get_sgtable(dev, info->table, info->cpu_addr, > + info->handle, len)) This isn't the right way to do it. I suppose the right thing is: if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len)) regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web