Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1194057

Re: [PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem

Show all headers | View raw

The subject isn't right.  You aren't patch checkpatch.pl itself you're
patching android.

The version doesn't go in the subject.

The subject is too vague.

On Tue, Jul 28, 2015 at 03:28:33PM +0530, Jignesh R Patel wrote:
> From: Jignesh R Patel <jigneshpatel0103@gmail.com>

Not needed.

> 
> This patch fix coding style problem of more then
> 80 character in one line. This patch does not change any
> logic.
> 
> Signed-off-by: Jignesh R Patel <jigneshpatel0103@gmail.com>
> ---
>  drivers/staging/android/ion/ion_cma_heap.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
> index 86b91fd..4a9a7bd 100644
> --- a/drivers/staging/android/ion/ion_cma_heap.c
> +++ b/drivers/staging/android/ion/ion_cma_heap.c
> @@ -73,7 +73,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  	if (!info->table)
>  		goto free_mem;
>  
> -	if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len))
> +	if (dma_get_sgtable(dev, info->table, info->cpu_addr,
> +						info->handle, len))

This isn't the right way to do it.  I suppose the right thing is:

	if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle,
			    len))

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem Jignesh R Patel <jigneshpatel0103@gmail.com> - 2015-07-28 12:00 +0200
  Re: [PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding  style problem Dan Carpenter <dan.carpenter@oracle.com> - 2015-07-28 12:20 +0200

csiph-web