Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1192864 > unrolled thread

Re: [PATCH 3/4] cp210x: Store part number

Started byOliver Neukum <oneukum@suse.com>
First post2015-07-27 11:30 +0200
Last post2015-07-27 11:30 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 3/4] cp210x: Store part number Oliver Neukum <oneukum@suse.com> - 2015-07-27 11:30 +0200

#1192864 — Re: [PATCH 3/4] cp210x: Store part number

FromOliver Neukum <oneukum@suse.com>
Date2015-07-27 11:30 +0200
SubjectRe: [PATCH 3/4] cp210x: Store part number
Message-ID<pQMTr-5RC-59@gated-at.bofh.it>
On Mon, 2015-07-27 at 08:50 +0200, Petr Tesarik wrote:
> I don't understand. While you're right that I copied this part from
> Sillicon Labs' driver without much thinking, and &spriv->bPartNumber
> can be used directly, I can't see any DMA on stack. FWIW
> cp210x_control_msg always allocates a buffer using kcalloc:
> 
>         buf = kcalloc(length, sizeof(__le32), GFP_KERNEL);
> /* ... */
>         result = usb_control_msg(serial->dev,
> usb_rcvctrlpipe(serial->dev, 0),
>                                  request, requesttype, value,
>                                  spriv->bInterfaceNumber, buf, size,
> timeout);
> 
> Is that what you mean?

Yes, sorry, that part wasn't so clear from the previous patch.

	Sorry
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web