Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1192864
| From | Oliver Neukum <oneukum@suse.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/4] cp210x: Store part number |
| Date | 2015-07-27 11:30 +0200 |
| Message-ID | <pQMTr-5RC-59@gated-at.bofh.it> (permalink) |
| References | <pPEXU-6lh-9@gated-at.bofh.it> <pPEXU-6lh-17@gated-at.bofh.it> <pQujL-4to-3@gated-at.bofh.it> <pQKye-2nk-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 2015-07-27 at 08:50 +0200, Petr Tesarik wrote: > I don't understand. While you're right that I copied this part from > Sillicon Labs' driver without much thinking, and &spriv->bPartNumber > can be used directly, I can't see any DMA on stack. FWIW > cp210x_control_msg always allocates a buffer using kcalloc: > > buf = kcalloc(length, sizeof(__le32), GFP_KERNEL); > /* ... */ > result = usb_control_msg(serial->dev, > usb_rcvctrlpipe(serial->dev, 0), > request, requesttype, value, > spriv->bInterfaceNumber, buf, size, > timeout); > > Is that what you mean? Yes, sorry, that part wasn't so clear from the previous patch. Sorry Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 3/4] cp210x: Store part number Oliver Neukum <oneukum@suse.com> - 2015-07-27 11:30 +0200
csiph-web