Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1190332 > unrolled thread
| Started by | Mike Kravetz <mike.kravetz@oracle.com> |
|---|---|
| First post | 2015-07-23 00:30 +0200 |
| Last post | 2015-07-23 00:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 09/10] hugetlbfs: add hugetlbfs_fallocate() Mike Kravetz <mike.kravetz@oracle.com> - 2015-07-23 00:30 +0200
Re: [PATCH v4 09/10] hugetlbfs: add hugetlbfs_fallocate() Andrew Morton <akpm@linux-foundation.org> - 2015-07-23 00:40 +0200
| From | Mike Kravetz <mike.kravetz@oracle.com> |
|---|---|
| Date | 2015-07-23 00:30 +0200 |
| Subject | Re: [PATCH v4 09/10] hugetlbfs: add hugetlbfs_fallocate() |
| Message-ID | <pPaGu-4uk-5@gated-at.bofh.it> |
On 07/22/2015 03:03 PM, Andrew Morton wrote: > On Tue, 21 Jul 2015 11:09:43 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote: ... >> + >> + if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE)) >> + return -EOPNOTSUPP; > > EOPNOTSUPP is a networking thing. It's inappropriate here. > > The problem is that if this error is ever returned to userspace, the > user will be sitting looking at "Operation not supported on transport > endpoint" and wondering what went wrong in the networking stack. Trying to follow FALLOCATE(2) man page: "EOPNOTSUPP The filesystem containing the file referred to by fd does not support this operation; or the mode is not supported by the filesystem containing the file referred to by fd." -- Mike Kravetz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Date | 2015-07-23 00:40 +0200 |
| Message-ID | <pPaQa-4FE-5@gated-at.bofh.it> |
| In reply to | #1190332 |
On Wed, 22 Jul 2015 15:23:42 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote: > On 07/22/2015 03:03 PM, Andrew Morton wrote: > > On Tue, 21 Jul 2015 11:09:43 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote: > ... > >> + > >> + if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE)) > >> + return -EOPNOTSUPP; > > > > EOPNOTSUPP is a networking thing. It's inappropriate here. > > > > The problem is that if this error is ever returned to userspace, the > > user will be sitting looking at "Operation not supported on transport > > endpoint" and wondering what went wrong in the networking stack. > > Trying to follow FALLOCATE(2) man page: > > "EOPNOTSUPP > The filesystem containing the file referred to by fd does not > support this operation; or the mode is not supported by the > filesystem containing the file referred to by fd." > Sigh. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web