Groups > linux.kernel > #1190332

Re: [PATCH v4 09/10] hugetlbfs: add hugetlbfs_fallocate()

From	Mike Kravetz <mike.kravetz@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 09/10] hugetlbfs: add hugetlbfs_fallocate()
Date	2015-07-23 00:30 +0200
Message-ID	<pPaGu-4uk-5@gated-at.bofh.it> (permalink)
References	<pOKiZ-7F0-7@gated-at.bofh.it> <pOKiZ-7F0-5@gated-at.bofh.it> <pPan8-46e-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/22/2015 03:03 PM, Andrew Morton wrote:
> On Tue, 21 Jul 2015 11:09:43 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
...
>> +
>> +	if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE))
>> +		return -EOPNOTSUPP;
>
> EOPNOTSUPP is a networking thing.  It's inappropriate here.
>
> The problem is that if this error is ever returned to userspace, the
> user will be sitting looking at "Operation not supported on transport
> endpoint" and wondering what went wrong in the networking stack.

Trying to follow FALLOCATE(2) man page:

"EOPNOTSUPP
	The filesystem containing the file referred to by  fd  does  not
	support  this  operation;  or  the  mode is not supported by the
	filesystem containing the file referred to by fd."

-- 
Mike Kravetz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 09/10] hugetlbfs: add hugetlbfs_fallocate() Mike Kravetz <mike.kravetz@oracle.com> - 2015-07-23 00:30 +0200
  Re: [PATCH v4 09/10] hugetlbfs: add hugetlbfs_fallocate() Andrew Morton <akpm@linux-foundation.org> - 2015-07-23 00:40 +0200

csiph-web