Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1190130 > unrolled thread
| Started by | "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> |
|---|---|
| First post | 2015-07-22 19:30 +0200 |
| Last post | 2015-07-22 19:40 +0200 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] iwlwifi:Fix error handling in the function iwl_pcie_enqueue_hcmd "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2015-07-22 19:30 +0200
Re: [linuxwifi] [PATCH] iwlwifi:Fix error handling in the function iwl_pcie_enqueue_hcmd "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2015-07-22 19:40 +0200
| From | "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> |
|---|---|
| Date | 2015-07-22 19:30 +0200 |
| Subject | Re: [PATCH] iwlwifi:Fix error handling in the function iwl_pcie_enqueue_hcmd |
| Message-ID | <pP60d-6bF-59@gated-at.bofh.it> |
On 07/22/2015 07:39 PM, Nicholas Krause wrote: > This fixes error handling in the function iwl_pcie_enqueue_hcmd > by checking if all calls to the function wl_pcie_txq_build_tfd > have failed by returning a error code and if so jump to the goto > label out from the cleaning up of acquired resources before What tests did you run on your patch? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> |
|---|---|
| Date | 2015-07-22 19:40 +0200 |
| Subject | Re: [linuxwifi] [PATCH] iwlwifi:Fix error handling in the function iwl_pcie_enqueue_hcmd |
| Message-ID | <pP69P-6mP-1@gated-at.bofh.it> |
| In reply to | #1190130 |
On 07/22/2015 08:30 PM, nick wrote: > > > On 2015-07-22 01:28 PM, Grumbach, Emmanuel wrote: >> >> >> On 07/22/2015 07:39 PM, Nicholas Krause wrote: >>> This fixes error handling in the function iwl_pcie_enqueue_hcmd >>> by checking if all calls to the function wl_pcie_txq_build_tfd >>> have failed by returning a error code and if so jump to the goto >>> label out from the cleaning up of acquired resources before >> >> What tests did you run on your patch? >> > None did I miss something? I can't really accept a patch if you don't even test it, right? Your patch doesn't look problematic at first glance, but hitting these paths isn't easy and I am not very happy to change the behavior without direct testing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web