Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1190132
| From | "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [linuxwifi] [PATCH] iwlwifi:Fix error handling in the function iwl_pcie_enqueue_hcmd |
| Date | 2015-07-22 19:40 +0200 |
| Message-ID | <pP69P-6mP-1@gated-at.bofh.it> (permalink) |
| References | <pP60d-6bF-61@gated-at.bofh.it> <pP60d-6bF-59@gated-at.bofh.it> <pP69P-6mP-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 07/22/2015 08:30 PM, nick wrote: > > > On 2015-07-22 01:28 PM, Grumbach, Emmanuel wrote: >> >> >> On 07/22/2015 07:39 PM, Nicholas Krause wrote: >>> This fixes error handling in the function iwl_pcie_enqueue_hcmd >>> by checking if all calls to the function wl_pcie_txq_build_tfd >>> have failed by returning a error code and if so jump to the goto >>> label out from the cleaning up of acquired resources before >> >> What tests did you run on your patch? >> > None did I miss something? I can't really accept a patch if you don't even test it, right? Your patch doesn't look problematic at first glance, but hitting these paths isn't easy and I am not very happy to change the behavior without direct testing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH] iwlwifi:Fix error handling in the function iwl_pcie_enqueue_hcmd "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2015-07-22 19:30 +0200 Re: [linuxwifi] [PATCH] iwlwifi:Fix error handling in the function iwl_pcie_enqueue_hcmd "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com> - 2015-07-22 19:40 +0200
csiph-web