Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1187876 > unrolled thread

Re: [rtc-linux] [PATCH] driver: rtc: use rtc_valid_tm() error code when reading date/time

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [rtc-linux] [PATCH] driver: rtc: use rtc_valid_tm() error code  when reading date/time Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-07-20 00:10 +0200

#1187876 — Re: [rtc-linux] [PATCH] driver: rtc: use rtc_valid_tm() error code when reading date/time

On 16/06/2015 at 11:35:19 +0200, rnd4@dave-tech.it wrote :
> From: Andrea Scian <andrea.scian@dave.eu>
> 
> There's a wrong commend in some RTC driver that say it's better to ignore
> rtc_valid_tm() when reading RTC timestamp. However this is wrong and is
> better to return to the userspace the an error if timestamp is not valid.
> 
> Signed-off-by: Andrea Scian <andrea.scian@dave.eu>
> ---
>  drivers/rtc/rtc-isl12022.c |    7 +------
>  drivers/rtc/rtc-pcf2123.c  |    8 +-------
>  drivers/rtc/rtc-pcf2127.c  |    8 +-------
>  drivers/rtc/rtc-pcf8563.c  |    8 +-------
>  4 files changed, 4 insertions(+), 27 deletions(-)
> 

Applied, after dropping the pcf8563 part as it was part of another
patch.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web