Re: [rtc-linux] [PATCH] driver: rtc: use rtc_valid_tm() error code when reading date/time

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [rtc-linux] [PATCH] driver: rtc: use rtc_valid_tm() error code when reading date/time
Date	2015-07-20 00:10 +0200
Message-ID	<pO4Wu-7f0-23@gated-at.bofh.it> (permalink)
References	<pBEXL-7X8-3@gated-at.bofh.it> <pO4Wu-7f0-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 16/06/2015 at 11:35:19 +0200, rnd4@dave-tech.it wrote :
> From: Andrea Scian <andrea.scian@dave.eu>
> 
> There's a wrong commend in some RTC driver that say it's better to ignore
> rtc_valid_tm() when reading RTC timestamp. However this is wrong and is
> better to return to the userspace the an error if timestamp is not valid.
> 
> Signed-off-by: Andrea Scian <andrea.scian@dave.eu>
> ---
>  drivers/rtc/rtc-isl12022.c |    7 +------
>  drivers/rtc/rtc-pcf2123.c  |    8 +-------
>  drivers/rtc/rtc-pcf2127.c  |    8 +-------
>  drivers/rtc/rtc-pcf8563.c  |    8 +-------
>  4 files changed, 4 insertions(+), 27 deletions(-)
> 

Applied, after dropping the pcf8563 part as it was part of another
patch.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [rtc-linux] [PATCH] driver: rtc: use rtc_valid_tm() error code  when reading date/time Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-07-20 00:10 +0200

csiph-web