Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1184371 > unrolled thread

Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

Started byAxel Lin <axel.lin@ingics.com>
First post2015-07-15 09:10 +0200
Last post2015-07-15 10:40 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for  optional GPIOs Axel Lin <axel.lin@ingics.com> - 2015-07-15 09:10 +0200
    Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for  optional GPIOs Kishon Vijay Abraham I <kishon@ti.com> - 2015-07-15 10:20 +0200
      Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for  optional GPIOs Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-07-15 10:30 +0200
        Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for  optional GPIOs Axel Lin <axel.lin@ingics.com> - 2015-07-15 10:40 +0200

#1184371 — Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

FromAxel Lin <axel.lin@ingics.com>
Date2015-07-15 09:10 +0200
SubjectRe: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs
Message-ID<pMoZk-dQ-5@gated-at.bofh.it>
2015-06-20 15:39 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> Also simplify the code a bit by specify direction and initial value for
> output in devm_gpiod_get_optional function.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> Hi
> This patch was sent on https://lkml.org/lkml/2015/5/31/221 with ACKs.
> It's still not in linux-next, so here is a resend.

Hi Kishon,
No response from Felipe.
The phy-tusb1210 driver is already in Linus' tree, maybe you can pick
up this patch.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1184412

FromKishon Vijay Abraham I <kishon@ti.com>
Date2015-07-15 10:20 +0200
Message-ID<pMq54-1Kj-19@gated-at.bofh.it>
In reply to#1184371
Hi,

On Wednesday 15 July 2015 12:34 PM, Axel Lin wrote:
> 2015-06-20 15:39 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
>> Also simplify the code a bit by specify direction and initial value for
>> output in devm_gpiod_get_optional function.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>> Hi
>> This patch was sent on https://lkml.org/lkml/2015/5/31/221 with ACKs.
>> It's still not in linux-next, so here is a resend.
> 
> Hi Kishon,
> No response from Felipe.
> The phy-tusb1210 driver is already in Linus' tree, maybe you can pick
> up this patch.

A similar patch was done by Uwe [1]. But since you've sent this patch before
Uwe, IMO your patch must be merged.

Uwe,
How do you want this patch to be merged. Is it okay If I take this in PHY tree?
Can you give your Acked-by?

Thanks
Kishon

[1] -> https://www.mail-archive.com/linux-media@vger.kernel.org/msg90203.html
> 
> Regards,
> Axel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1184417

FromUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date2015-07-15 10:30 +0200
Message-ID<pMqeK-1Vx-11@gated-at.bofh.it>
In reply to#1184412
Hello,

On Wed, Jul 15, 2015 at 01:45:44PM +0530, Kishon Vijay Abraham I wrote:
> Hi,
> 
> On Wednesday 15 July 2015 12:34 PM, Axel Lin wrote:
> > 2015-06-20 15:39 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> >> Also simplify the code a bit by specify direction and initial value for
> >> output in devm_gpiod_get_optional function.
> >>
> >> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> >> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> >> ---
> >> Hi
> >> This patch was sent on https://lkml.org/lkml/2015/5/31/221 with ACKs.
> >> It's still not in linux-next, so here is a resend.
> > 
> > Hi Kishon,
> > No response from Felipe.
> > The phy-tusb1210 driver is already in Linus' tree, maybe you can pick
> > up this patch.
> 
> A similar patch was done by Uwe [1]. But since you've sent this patch before
> Uwe, IMO your patch must be merged.
> 
> Uwe,
> How do you want this patch to be merged. Is it okay If I take this in PHY tree?
> Can you give your Acked-by?
I intend to change the gpiod functions to make the flags mandatory
for 4.3. I already sent the respective change to Linus Walleij to pull
for next and my commit to fix phy-tusb1210 is included to not break this
driver.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1184422

FromAxel Lin <axel.lin@ingics.com>
Date2015-07-15 10:40 +0200
Message-ID<pMqoq-26J-13@gated-at.bofh.it>
In reply to#1184417
2015-07-15 16:29 GMT+08:00 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> Hello,
>
> On Wed, Jul 15, 2015 at 01:45:44PM +0530, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Wednesday 15 July 2015 12:34 PM, Axel Lin wrote:
>> > 2015-06-20 15:39 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
>> >> Also simplify the code a bit by specify direction and initial value for
>> >> output in devm_gpiod_get_optional function.
>> >>
>> >> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> >> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> >> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>> >> ---
>> >> Hi
>> >> This patch was sent on https://lkml.org/lkml/2015/5/31/221 with ACKs.
>> >> It's still not in linux-next, so here is a resend.
>> >
>> > Hi Kishon,
>> > No response from Felipe.
>> > The phy-tusb1210 driver is already in Linus' tree, maybe you can pick
>> > up this patch.
>>
>> A similar patch was done by Uwe [1]. But since you've sent this patch before
>> Uwe, IMO your patch must be merged.
>>
>> Uwe,
>> How do you want this patch to be merged. Is it okay If I take this in PHY tree?
>> Can you give your Acked-by?
> I intend to change the gpiod functions to make the flags mandatory
> for 4.3. I already sent the respective change to Linus Walleij to pull
> for next and my commit to fix phy-tusb1210 is included to not break this
> driver.

I'm fine to just apply Uwe's patch if it make things easier.

Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web