Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs

From	Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for optional GPIOs
Date	2015-07-15 10:30 +0200
Message-ID	<pMqeK-1Vx-11@gated-at.bofh.it> (permalink)
References	<pDlHj-8gF-9@gated-at.bofh.it> <pMoZk-dQ-5@gated-at.bofh.it> <pMq54-1Kj-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Wed, Jul 15, 2015 at 01:45:44PM +0530, Kishon Vijay Abraham I wrote:
> Hi,
> 
> On Wednesday 15 July 2015 12:34 PM, Axel Lin wrote:
> > 2015-06-20 15:39 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> >> Also simplify the code a bit by specify direction and initial value for
> >> output in devm_gpiod_get_optional function.
> >>
> >> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> >> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> >> ---
> >> Hi
> >> This patch was sent on https://lkml.org/lkml/2015/5/31/221 with ACKs.
> >> It's still not in linux-next, so here is a resend.
> > 
> > Hi Kishon,
> > No response from Felipe.
> > The phy-tusb1210 driver is already in Linus' tree, maybe you can pick
> > up this patch.
> 
> A similar patch was done by Uwe [1]. But since you've sent this patch before
> Uwe, IMO your patch must be merged.
> 
> Uwe,
> How do you want this patch to be merged. Is it okay If I take this in PHY tree?
> Can you give your Acked-by?
I intend to change the gpiod functions to make the flags mandatory
for 4.3. I already sent the respective change to Linus Walleij to pull
for next and my commit to fix phy-tusb1210 is included to not break this
driver.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for  optional GPIOs Axel Lin <axel.lin@ingics.com> - 2015-07-15 09:10 +0200
  Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for  optional GPIOs Kishon Vijay Abraham I <kishon@ti.com> - 2015-07-15 10:20 +0200
    Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for  optional GPIOs Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-07-15 10:30 +0200
      Re: [PATCH RESEND] phy: tusb1210: Use devm_gpiod_get_optional for  optional GPIOs Axel Lin <axel.lin@ingics.com> - 2015-07-15 10:40 +0200

csiph-web