Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1184375 > unrolled thread

Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops

Started byAxel Lin <axel.lin@ingics.com>
First post2015-07-15 09:20 +0200
Last post2015-07-15 10:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops Axel Lin <axel.lin@ingics.com> - 2015-07-15 09:20 +0200
    Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops Kishon Vijay Abraham I <kishon@ti.com> - 2015-07-15 10:10 +0200

#1184375 — Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops

FromAxel Lin <axel.lin@ingics.com>
Date2015-07-15 09:20 +0200
SubjectRe: [PATCH] phy: ulpi_phy: Add const qualifier to ops
Message-ID<pMp8Z-p8-7@gated-at.bofh.it>
2015-06-05 8:27 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> The ops is never changed in ulpi_phy_create(), so make it const.

Hi Kishon,

Would you pick up this patch?
Without this patch, passing a const struct phy_ops* to ulip_phy_create will
have compiler warning.
It should be fine to pass a const struct phy_ops* to ulip_phy_create and
since the drivers usually never change phy_ops after initialized,
it can be const.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1184408

FromKishon Vijay Abraham I <kishon@ti.com>
Date2015-07-15 10:10 +0200
Message-ID<pMpVn-1yY-13@gated-at.bofh.it>
In reply to#1184375
Hi Axel,

On Wednesday 15 July 2015 12:40 PM, Axel Lin wrote:
> 2015-06-05 8:27 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
>> The ops is never changed in ulpi_phy_create(), so make it const.
> 
> Hi Kishon,
> 
> Would you pick up this patch?

yes.. I'll take once I start queuing the patches.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web