Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1184375

Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops

From Axel Lin <axel.lin@ingics.com>
Newsgroups linux.kernel
Subject Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops
Date 2015-07-15 09:20 +0200
Message-ID <pMp8Z-p8-7@gated-at.bofh.it> (permalink)
References <pxNGh-nY-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


2015-06-05 8:27 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> The ops is never changed in ulpi_phy_create(), so make it const.

Hi Kishon,

Would you pick up this patch?
Without this patch, passing a const struct phy_ops* to ulip_phy_create will
have compiler warning.
It should be fine to pass a const struct phy_ops* to ulip_phy_create and
since the drivers usually never change phy_ops after initialized,
it can be const.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops Axel Lin <axel.lin@ingics.com> - 2015-07-15 09:20 +0200
  Re: [PATCH] phy: ulpi_phy: Add const qualifier to ops Kishon Vijay Abraham I <kishon@ti.com> - 2015-07-15 10:10 +0200

csiph-web