Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1181734 > unrolled thread

Re: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for  USB0 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-07-10 18:40 +0200
    RE: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for  USB0 Phil Edworthy <phil.edworthy@renesas.com> - 2015-07-13 11:10 +0200
      Re: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for  USB0 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-07-13 12:20 +0200

#1181734 — Re: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0

Hello.

On 07/07/2015 02:55 PM, Phil Edworthy wrote:

> Instead of statically selecting the PHY connection to either the
> USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
> dts to specifiy gpio pins for the vbus and id signals. Additional

    These GPIOs don't have anything to do with the PHY, they're interfacing 
Maxim MAX3355 OTG chip for which I have submitted the extcon driver.

> gpio pins are used to control power to an external OTG device and
> an override to turn vbus on/off.

> Note: the R-Car USB PHY only allows this Host/Function switching
> on channel 0.

> This has been tested on a r8a7791 based Koelsch board, which uses
> a MAX3355 device to supply vbus power when needed.

> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>

    I'm inclined to NAK this. You're modifying the wrong driver, I think.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1182621

Hi Sergei,

On 10 July 2015 17:36, Sergei wrote:
> Hello.
> 
> On 07/07/2015 02:55 PM, Phil Edworthy wrote:
> 
> > Instead of statically selecting the PHY connection to either the
> > USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
> > dts to specifiy gpio pins for the vbus and id signals. Additional
> 
>     These GPIOs don't have anything to do with the PHY, they're interfacing
> Maxim MAX3355 OTG chip for which I have submitted the extcon driver.
Hmm, I see what you mean... could you post your latest version of that
driver as it seems to have stalled 6 months ago?
 

> > gpio pins are used to control power to an external OTG device and
> > an override to turn vbus on/off.
> 
> > Note: the R-Car USB PHY only allows this Host/Function switching
> > on channel 0.
> 
> > This has been tested on a r8a7791 based Koelsch board, which uses
> > a MAX3355 device to supply vbus power when needed.
> 
> > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> 
>     I'm inclined to NAK this. You're modifying the wrong driver, I think.
> 
> WBR, Sergei

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1182693

Hello.

On 7/13/2015 12:04 PM, Phil Edworthy wrote:

>>> Instead of statically selecting the PHY connection to either the
>>> USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
>>> dts to specifiy gpio pins for the vbus and id signals. Additional

>>      These GPIOs don't have anything to do with the PHY, they're interfacing

    Perhaps that was too strong statement but nevertheless...

>> Maxim MAX3355 OTG chip for which I have submitted the extcon driver.

> Hmm, I see what you mean... could you post your latest version of that
> driver as it seems to have stalled 6 months ago?

    I haven't worked on that driver since then.

> Thanks
> Phil

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web