Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1181734

Re: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0

Show all headers | View raw

Hello.

On 07/07/2015 02:55 PM, Phil Edworthy wrote:

> Instead of statically selecting the PHY connection to either the
> USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
> dts to specifiy gpio pins for the vbus and id signals. Additional

    These GPIOs don't have anything to do with the PHY, they're interfacing 
Maxim MAX3355 OTG chip for which I have submitted the extcon driver.

> gpio pins are used to control power to an external OTG device and
> an override to turn vbus on/off.

> Note: the R-Car USB PHY only allows this Host/Function switching
> on channel 0.

> This has been tested on a r8a7791 based Koelsch board, which uses
> a MAX3355 device to supply vbus power when needed.

> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>

    I'm inclined to NAK this. You're modifying the wrong driver, I think.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for  USB0 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-07-10 18:40 +0200
  RE: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for  USB0 Phil Edworthy <phil.edworthy@renesas.com> - 2015-07-13 11:10 +0200
    Re: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for  USB0 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-07-13 12:20 +0200

csiph-web