Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1180676 > unrolled thread

Re: [PATCH v2] HID: Wacom: Delete unnecessary checks before the function call "input_free_device"

Started byJiri Kosina <jkosina@suse.com>
First post2015-07-09 14:30 +0200
Last post2015-07-09 14:30 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v2] HID: Wacom: Delete unnecessary checks before the  function call "input_free_device" Jiri Kosina <jkosina@suse.com> - 2015-07-09 14:30 +0200

#1180676 — Re: [PATCH v2] HID: Wacom: Delete unnecessary checks before the function call "input_free_device"

FromJiri Kosina <jkosina@suse.com>
Date2015-07-09 14:30 +0200
SubjectRe: [PATCH v2] HID: Wacom: Delete unnecessary checks before the function call "input_free_device"
Message-ID<pKj7J-6i-31@gated-at.bofh.it>
On Thu, 9 Jul 2015, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 9 Jul 2015 08:00:10 +0200
> 
> The input_free_device() function tests whether its argument is NULL and
> then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

This is really on a "is it worth it?" borderline, but anyway ... applied 
to for-4.3/upstream.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web