Re: [PATCH v2] HID: Wacom: Delete unnecessary checks before the function call "input_free_device"

From	Jiri Kosina <jkosina@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] HID: Wacom: Delete unnecessary checks before the function call "input_free_device"
Date	2015-07-09 14:30 +0200
Message-ID	<pKj7J-6i-31@gated-at.bofh.it> (permalink)
References	(14 earlier) <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <orRlL-5aa-3@gated-at.bofh.it> <pKdbX-51w-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 9 Jul 2015, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 9 Jul 2015 08:00:10 +0200
> 
> The input_free_device() function tests whether its argument is NULL and
> then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

This is really on a "is it worth it?" borderline, but anyway ... applied 
to for-4.3/upstream.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] HID: Wacom: Delete unnecessary checks before the  function call "input_free_device" Jiri Kosina <jkosina@suse.com> - 2015-07-09 14:30 +0200

csiph-web