Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1179856 > unrolled thread
| Started by | Pavel Machek <pavel@ucw.cz> |
|---|---|
| First post | 2015-07-08 16:00 +0200 |
| Last post | 2015-07-09 13:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: kdbus: to merge or not to merge? Pavel Machek <pavel@ucw.cz> - 2015-07-08 16:00 +0200
Re: kdbus: to merge or not to merge? Geert Uytterhoeven <geert@linux-m68k.org> - 2015-07-09 10:50 +0200
Re: kdbus: to merge or not to merge? Pavel Machek <pavel@ucw.cz> - 2015-07-09 13:40 +0200
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2015-07-08 16:00 +0200 |
| Subject | Re: kdbus: to merge or not to merge? |
| Message-ID | <pJY3h-3ql-33@gated-at.bofh.it> |
On Mon 2015-06-22 23:41:40, Greg KH wrote: > On Mon, Jun 22, 2015 at 11:06:09PM -0700, Andy Lutomirski wrote: > > Hi Linus, > > > > Can you opine as to whether you think that kdbus should be merged? > > Ah, a preemptive pull request denial, how nice. > I don't think I've ever seen such a thing before, congratulations for > creating something so must have previously been lacking in our > development model in how to work together in a community in a productive > manner. Apparently, new tools are needed in the community, as normal review comments did not stop drivers/android/binder.c merge. For example binder_transaction does not exactly look like a kernel code, "TODO: fput" does not really invoke confidence, and ammount of BUG_ON()s is quite amazing... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2015-07-09 10:50 +0200 |
| Message-ID | <pKfGP-6mA-13@gated-at.bofh.it> |
| In reply to | #1179856 |
On Wed, Jul 8, 2015 at 3:54 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Apparently, new tools are needed in the community, as normal review
> comments did not stop drivers/android/binder.c merge.
>
> For example binder_transaction does not exactly look like a kernel
> code, "TODO: fput" does not really invoke confidence, and ammount of
> BUG_ON()s is quite amazing...
Amazingly, checkpatch (without --strict) only complains about long lines.
Seems like the test for "BUG" is (and always has been) commented out...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2015-07-09 13:40 +0200 |
| Message-ID | <pKilj-81W-1@gated-at.bofh.it> |
| In reply to | #1180556 |
On Thu 2015-07-09 10:39:58, Geert Uytterhoeven wrote: > On Wed, Jul 8, 2015 at 3:54 PM, Pavel Machek <pavel@ucw.cz> wrote: > > Apparently, new tools are needed in the community, as normal review > > comments did not stop drivers/android/binder.c merge. > > > > For example binder_transaction does not exactly look like a kernel > > code, "TODO: fput" does not really invoke confidence, and ammount of > > BUG_ON()s is quite amazing... > > Amazingly, checkpatch (without --strict) only complains about long lines. Well, checkpatch only tells half of storry. Anyway worst problem is that there's no documentation of kernel<->user interface binder provides, making understanding it hard/impossible. Closest to documentation pointer is: * Based on, but no longer compatible with, the original * OpenBinder.org binder driver interface, which is: Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web